Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion livekit-agents/livekit/agents/job.py
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,10 @@
_JobContextVar = contextvars.ContextVar["JobContext"]("agents_job_context")


def _serialize_session_report(report: SessionReport) -> str:
return json.dumps(report.to_dict(), indent=2, default=str)


def _observability_url(livekit_url: str) -> str | None:
"""Return the observability endpoint, or None if observability is unavailable."""
url = os.environ.get("LIVEKIT_OBSERVABILITY_URL")
Expand Down Expand Up @@ -266,7 +270,7 @@ async def _on_session_end(self) -> None:
# console recording, dump data to a local file
if c.enabled and c.record:
try:
report_json = json.dumps(report.to_dict(), indent=2)
report_json = _serialize_session_report(report)

import aiofiles
import aiofiles.os
Expand Down
14 changes: 14 additions & 0 deletions tests/test_recording.py
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@

import contextlib
import inspect
import json
from collections.abc import Iterator
from pathlib import Path
from typing import Any
Expand All @@ -11,6 +12,7 @@
import pytest

from livekit.agents import Agent, AgentSession
from livekit.agents.job import _serialize_session_report
from livekit.agents.telemetry.traces import _upload_session_report
from livekit.agents.voice.agent_session import (
_RECORDING_ALL_OFF,
Expand Down Expand Up @@ -128,6 +130,18 @@ def _make_mock_http() -> MagicMock:
return mock_http


def test_serialize_session_report_handles_non_json_event_values() -> None:
class NonSerializable:
pass

report = MagicMock()
report.to_dict.return_value = {"events": [{"interruption_detector": NonSerializable()}]}

payload = json.loads(_serialize_session_report(report))

assert "NonSerializable" in payload["events"][0]["interruption_detector"]


def _observability_endpoint_arg(func: Any) -> dict[str, str]:
"""Build endpoint kwargs for old/new telemetry function signatures."""
if "observability_url" in inspect.signature(func).parameters:
Expand Down
Loading