-
-
Notifications
You must be signed in to change notification settings - Fork 175
Custom Validation #259
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Custom Validation #259
Changes from 5 commits
2360bb9
cf6ede2
a671734
1d76300
fee749d
cf6d485
bcca647
c4e686d
4a24aed
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -69,6 +69,19 @@ func ({{$action.Short}} *{{ $.Pascal }}{{$action.Pascal}}Action) handler(httpRes | |
| JSON: response.Status(400).Set("Content-Type", "application/json").JSON(map[string]string{"error": err.Error()}), | ||
| } | ||
| } | ||
| // validate input | ||
| {{- if (index $action.Params 0).HasValidate }} | ||
| // single input struct has validate method | ||
| if err := in.Validate(); err != nil { | ||
|
jfmario marked this conversation as resolved.
Outdated
|
||
| return &response.Format{ | ||
| {{- if ne $action.Method "GET" }} | ||
| HTML: response.Status(http.StatusSeeOther).RedirectBack(httpRequest.URL.Path), | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The big question is going to be what happens with the error message? Right now if a form fails, there's no feedback sent back to the user. Flash messages are typically the solution to this where you store a value in a cookie that gets removed after it's pulled out. I think the ultimate solution is to have the ability to add custom flash messages via the session, but if there's any temporary solution to get this working where you set the cookie, pull it out and pass to the view, I'd be open to pursuing that. Here's what I've thought about so far with sessions: #56. Otherwise maybe we only enable this for JSON? Does your use case fit with that limitation?
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Yea, I think flash messages should be the behavior here. I'm thinking to add some other stuff to this PR but then put in on pause until we have sessions and something like flash messages.
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Cool, sounds good! I'm going to get back to feature development very soon. Just trying to wrap up generator caching to allow for running more expensive generators (e.g. generators that call |
||
| {{- end }} | ||
| JSON: response.Status(400).Set("Content-Type", "application/json").JSON(map[string]string{"error": err.Error()}), | ||
| } | ||
| } | ||
| {{- end }} | ||
|
|
||
| {{- end }} | ||
| {{- with $provider := $action.Provider }} | ||
| controller, err := {{ $provider.Name }}( | ||
|
|
||
Uh oh!
There was an error while loading. Please reload this page.