Fix Vala deprecations and Meson warnings#283
Open
leigh123linux wants to merge 1 commit into
Open
Conversation
leigh123linux
force-pushed
the
fix_warnings
branch
from
bd31a18 to
b308931
Compare
There was a problem hiding this comment.
Pull request overview
This PR modernizes the Vala/GTK code to address deprecations and reduce warnings, primarily by replacing deprecated GTK styling/layout APIs with CSS-based styling and by making X11 casts/nullability checks explicit.
Changes:
- Replaced deprecated GTK widget properties/methods (e.g., margins,
override_*styling,Gtk.Alignment) with GTK3-supported alternatives. - Hardened several X11-specific code paths by guarding
as Gdk.X11.*casts and returning early when unavailable. - Updated Meson install rules and fixed some minor warning/noise issues (e.g., spelling, switch completeness).
Reviewed changes
Copilot reviewed 14 out of 14 changed files in this pull request and generated 10 comments.
Show a summary per file
| File | Description |
|---|---|
| src/user-list.vala | Adds safer casting when reading UserPromptBox properties. |
| src/user-avatar.vala | Replaces deprecated margin_right with margin_end. |
| src/slick-greeter.vala | Adds X11 null-guards for X11 window/display/screen/visual usage. |
| src/shutdown-dialog.vala | Replaces deprecated font/color overrides with CSS providers; adds null-guards for toplevel window usage. |
| src/settings.vala | Uses settings_schema.list_keys() instead of deprecated key listing. |
| src/prompt-box.vala | Introduces CSS helpers for font/color; replaces deprecated alignment/margins; adds null-guards for ComboBox child styling. |
| src/menubar.vala | Simplifies blur-surface creation; removes deprecated insensitive color overrides; improves null-safety when emitting focus-event. |
| src/main-window.vala | Replaces deprecated background override with CSS; replaces deprecated alignment usage; changes background surface setup. |
| src/list-stack.vala | Avoids unsafe cast when popping previous list. |
| src/idle-monitor.vala | Adds explicit X11 cast + (redundant) null-check for display backend. |
| src/dash-entry.vala | Replaces deprecated override_font with CSS provider usage. |
| src/dash-box.vala | Completes switch handling and simplifies blur-surface generation. |
| src/animate-timer.vala | Replaces deprecated/unwanted property form with a private easing function field. |
| files/meson.build | Adds follow_symlinks to install_subdir() calls. |
Comments suppressed due to low confidence (2)
src/menubar.vala:196
- This menu item is set
sensitive = false, so the clock label will render with the theme’s disabled color. Previously INSENSITIVE was overridden to match NORMAL, keeping the clock readable. Consider replacing the old override with a targeted CSS rule that sets the:disabledcolor for this label/item to the normal foreground.
clock_label = new Gtk.Label ("");
clock_label.show ();
var item = new Gtk.MenuItem ();
item.add (clock_label);
item.sensitive = false;
src/menubar.vala:256
- This hostname menu item is set
sensitive = false, so the label will render with the theme’s disabled color. Previously INSENSITIVE was overridden to match NORMAL, keeping the hostname readable. Consider replacing the old override with a targeted CSS rule for the:disabledstate of this label/item.
var label = new Gtk.Label (Posix.utsname ().nodename);
label.show ();
var hostname_item = new Gtk.MenuItem ();
hostname_item.add (label);
hostname_item.sensitive = false;
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+78
to
+82
| var font_provider = new Gtk.CssProvider (); | ||
| font_provider.load_from_data ("* { font-family: Ubuntu; font-size: 14pt; }", -1); | ||
| style_ctx.add_provider (font_provider, Gtk.STYLE_PROVIDER_PRIORITY_APPLICATION); | ||
| } | ||
| catch (Error e) |
Comment on lines
531
to
532
| apply_label_css_color (label, "Ubuntu Bold", 10, color); | ||
|
|
Comment on lines
+643
to
+647
| var combo_child = combo.get_child (); | ||
| if (combo_child != null) | ||
| { | ||
| combo_child.get_style_context ().add_class ("lightdm-combo"); | ||
| apply_label_css (combo_child, "Ubuntu", 14); |
| try | ||
| { | ||
| provider.load_from_data ( | ||
| "label { font-family: \"%s\"; font-size: %dpt; color: white; }" |
leigh123linux
force-pushed
the
fix_warnings
branch
5 times, most recently
from
1177966 to
bdcdcf6
Compare
Comment on lines
+93
to
+94
| p.load_from_data ("label { color: @theme_fg_color; } | ||
| label:disabled { color: @theme_fg_color; }", -1); |
Comment on lines
552
to
565
| private static Cairo.XlibSurface? create_root_surface (Gdk.Screen screen) | ||
| { | ||
| var visual = screen.get_system_visual (); | ||
|
|
||
| unowned X.Display display = (screen.get_display () as Gdk.X11.Display).get_xdisplay (); | ||
| unowned X.Screen xscreen = (screen as Gdk.X11.Screen).get_xscreen (); | ||
| var x11_display = screen.get_display () as Gdk.X11.Display; | ||
| var x11_screen = screen as Gdk.X11.Screen; | ||
| var x11_root = screen.get_root_window () as Gdk.X11.Window; | ||
| var x11_visual = visual as Gdk.X11.Visual; | ||
| if (x11_display == null || x11_screen == null || x11_root == null || x11_visual == null) | ||
| return null; | ||
|
|
||
| unowned X.Display display = x11_display.get_xdisplay (); | ||
| unowned X.Screen xscreen = x11_screen.get_xscreen (); | ||
|
|
Comment on lines
578
to
583
| if (l != null) | ||
| { | ||
| l.visible = true; | ||
| l.override_font (Pango.FontDescription.from_string ("Ubuntu Light 12")); | ||
| l.override_color (Gtk.StateFlags.NORMAL, { 1.0f, 1.0f, 1.0f, 0.0f }); | ||
| l.override_color (Gtk.StateFlags.FOCUSED, { 1.0f, 1.0f, 1.0f, 1.0f }); | ||
| l.override_color (Gtk.StateFlags.ACTIVE, { 1.0f, 1.0f, 1.0f, 1.0f }); | ||
| l.get_style_context ().add_provider (make_label_style ("Ubuntu Light", 12), Gtk.STYLE_PROVIDER_PRIORITY_APPLICATION); | ||
| this.get_accessible ().set_name (l.get_text ()); | ||
| } |
leigh123linux
force-pushed
the
fix_warnings
branch
from
bdcdcf6 to
18eb01c
Compare
leigh123linux
force-pushed
the
fix_warnings
branch
from
18eb01c to
8643a96
Compare
Comment on lines
74
to
+81
| var style_ctx = get_style_context (); | ||
|
|
||
| try | ||
| { | ||
| var font_provider = new Gtk.CssProvider (); | ||
| font_provider.load_from_data ("entry { font-family: Ubuntu; font-size: 14pt; }", -1); | ||
| style_ctx.add_provider (font_provider, Gtk.STYLE_PROVIDER_PRIORITY_APPLICATION); | ||
| } |
Comment on lines
+645
to
+656
| var combo_child = combo.get_child (); | ||
| if (combo_child != null) | ||
| { | ||
| combo_child.get_style_context ().add_class ("lightdm-combo"); | ||
| try | ||
| { | ||
| var p = new Gtk.CssProvider (); | ||
| p.load_from_data ("entry { font-family: \"Ubuntu\"; font-size: 14pt; }", -1); | ||
| combo_child.get_style_context ().add_provider (p, Gtk.STYLE_PROVIDER_PRIORITY_APPLICATION); | ||
| } | ||
| catch (Error e) { debug ("CSS combo entry error: %s", e.message); } | ||
| } |
Comment on lines
579
to
583
| { | ||
| l.visible = true; | ||
| l.override_font (Pango.FontDescription.from_string ("Ubuntu Light 12")); | ||
| l.override_color (Gtk.StateFlags.NORMAL, { 1.0f, 1.0f, 1.0f, 0.0f }); | ||
| l.override_color (Gtk.StateFlags.FOCUSED, { 1.0f, 1.0f, 1.0f, 1.0f }); | ||
| l.override_color (Gtk.StateFlags.ACTIVE, { 1.0f, 1.0f, 1.0f, 1.0f }); | ||
| l.get_style_context ().add_provider (make_label_style ("Ubuntu Light", 12), Gtk.STYLE_PROVIDER_PRIORITY_APPLICATION); | ||
| this.get_accessible ().set_name (l.get_text ()); | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
../src/settings.vala:68.25-68.43: warning:
GLib.Settings.list_keys' has been deprecated since 2.46 68 | string[] keys = gsettings.list_keys (); | ^~~~~~~~~~~~~~~~~~~ ../src/menubar.vala:729.42-729.82: warning: Access to possiblenull'. Perform a check or use an unsafe cast.729 | Signal.emit_by_name ((get_toplevel () as Gtk.Window).get_focus ().get_accessible (), "focus-event", true);
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
../src/shutdown-dialog.vala:561.13-561.27: warning:
Gtk.Widget.override_font' has been deprecated since 3.16 561 | l.override_font (Pango.FontDescription.from_string ("Ubuntu Light 12")); | ^~~~~~~~~~~~~~~ ../src/shutdown-dialog.vala:562.13-562.28: warning:Gtk.Widget.override_color' has been deprecated since 3.16562 | l.override_color (Gtk.StateFlags.NORMAL, { 1.0f, 1.0f, 1.0f, 0.0f });
| ^~~~~~~~~~~~~~~~
../src/shutdown-dialog.vala:563.13-563.28: warning:
Gtk.Widget.override_color' has been deprecated since 3.16 563 | l.override_color (Gtk.StateFlags.FOCUSED, { 1.0f, 1.0f, 1.0f, 1.0f }); | ^~~~~~~~~~~~~~~~ ../src/shutdown-dialog.vala:564.13-564.28: warning:Gtk.Widget.override_color' has been deprecated since 3.16564 | l.override_color (Gtk.StateFlags.ACTIVE, { 1.0f, 1.0f, 1.0f, 1.0f });
| ^~~~~~~~~~~~~~~~
../src/shutdown-dialog.vala:590.9-590.49: warning: Access to possible
null'. Perform a check or use an unsafe cast. 590 | (get_toplevel () as Gtk.Window).set_focus (null); | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ../src/shutdown-dialog.vala:107.13-107.37: warning:Gtk.Widget.override_font' has been deprecated since 3.16107 | title_label.override_font (Pango.FontDescription.from_string ("Ubuntu Light 15"));
| ^~~~~~~~~~~~~~~~~~~~~~~~~
../src/shutdown-dialog.vala:108.13-108.38: warning:
Gtk.Widget.override_color' has been deprecated since 3.16 108 | title_label.override_color (Gtk.StateFlags.NORMAL, { 1.0f, 1.0f, 1.0f, 1.0f }); | ^~~~~~~~~~~~~~~~~~~~~~~~~~ ../src/shutdown-dialog.vala:141.9-141.27: warning:Gtk.Widget.override_font' has been deprecated since 3.16141 | label.override_font (Pango.FontDescription.from_string ("Ubuntu Light 12"));
| ^~~~~~~~~~~~~~~~~~~
../src/shutdown-dialog.vala:142.9-142.28: warning:
Gtk.Widget.override_color' has been deprecated since 3.16 142 | label.override_color (Gtk.StateFlags.NORMAL, { 1.0f, 1.0f, 1.0f, 1.0f }); | ^~~~~~~~~~~~~~~~~~~~ ../src/shutdown-dialog.vala:339.9-339.50: warning: Access to possiblenull'. Perform a check or use an unsafe cast.339 | (get_toplevel () as Gtk.Window).move_focus (Gtk.DirectionType.TAB_FORWARD);
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
../src/shutdown-dialog.vala:344.9-344.50: warning: Access to possible
null'. Perform a check or use an unsafe cast. 344 | (get_toplevel () as Gtk.Window).move_focus (Gtk.DirectionType.TAB_BACKWARD); | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ../src/shutdown-dialog.vala:349.22-349.62: warning: Access to possiblenull'. Perform a check or use an unsafe cast.349 | var widget = (get_toplevel () as Gtk.Window).get_focus ();
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
../src/shutdown-dialog.vala:351.13-351.53: warning: Access to possible
null'. Perform a check or use an unsafe cast. 351 | (get_toplevel () as Gtk.Window).set_focus (null); | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ../src/menubar.vala:542.9-542.28: warning:Gtk.Widget.override_color' has been deprecated since 3.16542 | label.override_color (Gtk.StateFlags.INSENSITIVE, keyboard_fg);
| ^~~~~~~~~~~~~~~~~~~~
../src/menubar.vala:202.13-202.38: warning:
Gtk.Widget.override_color' has been deprecated since 3.16 202 | clock_label.override_color (Gtk.StateFlags.INSENSITIVE, clock_fg); | ^~~~~~~~~~~~~~~~~~~~~~~~~~ ../src/menubar.vala:226.13-226.38: warning:Gtk.Widget.override_color' has been deprecated since 3.16226 | power_label.override_color (Gtk.StateFlags.INSENSITIVE, power_fg);
| ^~~~~~~~~~~~~~~~~~~~~~~~~~
../src/menubar.vala:266.13-266.32: warning:
Gtk.Widget.override_color' has been deprecated since 3.16 266 | label.override_color (Gtk.StateFlags.INSENSITIVE, hostname_fg); | ^~~~~~~~~~~~~~~~~~~~ ../src/user-avatar.vala:35.9-35.20: warning:Gtk.Widget.margin_right' has been deprecated since 3.1235 | margin_right = AVATAR_MARGIN;
| ^~~~~~~~~~~~
../src/prompt-box.vala:217.9-217.32: warning:
Gtk.Widget.override_font' has been deprecated since 3.16 217 | name_label.override_font (Pango.FontDescription.from_string ("Ubuntu 13")); | ^~~~~~~~~~~~~~~~~~~~~~~~ ../src/prompt-box.vala:218.9-218.33: warning:Gtk.Widget.override_color' has been deprecated since 3.16218 | name_label.override_color (Gtk.StateFlags.NORMAL, { 1.0f, 1.0f, 1.0f, 1.0f });
| ^~~~~~~~~~~~~~~~~~~~~~~~~
../src/prompt-box.vala:222.9-222.30: warning:
Gtk.Widget.margin_left' has been deprecated since 3.12 222 | name_label.margin_left = 2; | ^~~~~~~~~~~~~~~~~~~~~~ ../src/prompt-box.vala:233.25-233.37: warning:Gtk.Alignment' has been deprecated since 3.14233 | var align = new Gtk.Alignment (0.5f, 0.5f, 0.0f, 0.0f);
| ^~~~~~~~~~~~~
../src/prompt-box.vala:233.13-233.17: warning:
Gtk.Alignment' has been deprecated since 3.14 233 | var align = new Gtk.Alignment (0.5f, 0.5f, 0.0f, 0.0f); | ^~~~~ ../src/prompt-box.vala:275.9-275.38: warning:Gtk.Widget.override_font' has been deprecated since 3.16275 | small_name_label.override_font (Pango.FontDescription.from_string ("Ubuntu 13"));
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
../src/prompt-box.vala:276.9-276.39: warning:
Gtk.Widget.override_color' has been deprecated since 3.16 276 | small_name_label.override_color (Gtk.StateFlags.NORMAL, { 1.0f, 1.0f, 1.0f, 1.0f }); | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ../src/prompt-box.vala:280.9-280.36: warning:Gtk.Widget.margin_left' has been deprecated since 3.12280 | small_name_label.margin_left = 2;
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
../src/prompt-box.vala:288.25-288.37: warning:
Gtk.Alignment' has been deprecated since 3.14 288 | var align = new Gtk.Alignment (0.5f, 0.5f, 0.0f, 0.0f); | ^~~~~~~~~~~~~ ../src/prompt-box.vala:288.13-288.17: warning:Gtk.Alignment' has been deprecated since 3.14288 | var align = new Gtk.Alignment (0.5f, 0.5f, 0.0f, 0.0f);
| ^~~~~
../src/dash-entry.vala:74.9-74.21: warning:
Gtk.Widget.override_font' has been deprecated since 3.16 74 | override_font (Pango.FontDescription.from_string (font)); | ^~~~~~~~~~~~~ ../src/prompt-box.vala:502.9-502.27: warning:Gtk.Widget.override_font' has been deprecated since 3.16502 | label.override_font (Pango.FontDescription.from_string ("Ubuntu Bold 10"));
| ^~~~~~~~~~~~~~~~~~~
../src/prompt-box.vala:507.9-507.28: warning:
Gtk.Widget.override_color' has been deprecated since 3.16 507 | label.override_color (Gtk.StateFlags.NORMAL, color); | ^~~~~~~~~~~~~~~~~~~~ ../src/prompt-box.vala:620.9-620.40: warning:Gtk.Widget.override_font' has been deprecated since 3.16620 | combo.get_child ().override_font (Pango.FontDescription.from_string (DashEntry.font));
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
../src/list-stack.vala:77.13-77.50: warning: Access to possible
null'. Perform a check or use an unsafe cast. 77 | (prev.data as GreeterList).greeter_box.pop (); | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ../src/main-window.vala:219.13-219.35: warning:Gtk.Widget.margin_left' has been deprecated since 3.12219 | content_box.margin_left = get_grid_offset (get_allocated_width ()) + (content_align == "left" ? grid_size : 0);
| ^~~~~~~~~~~~~~~~~~~~~~~
../src/main-window.vala:220.13-220.36: warning:
Gtk.Widget.margin_right' has been deprecated since 3.12 220 | content_box.margin_right = get_grid_offset (get_allocated_width ()) + (content_align == "right" ? grid_size : 0); | ^~~~~~~~~~~~~~~~~~~~~~~~ ../src/main-window.vala:229.33-229.48: warning:Gdk.cairo_create' has been deprecated since 3.22229 | background.set_surface (Gdk.cairo_create (get_window ()).get_target ());
| ^~~~~~~~~~~~~~~~
../src/user-list.vala:605.35-605.78: warning: Access to possible
null'. Perform a check or use an unsafe cast. 605 | new_background_file = (selected_entry as UserPromptBox).background; | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ../src/user-list.vala:654.23-654.63: warning: Access to possiblenull'. Perform a check or use an unsafe cast.654 | session = (selected_entry as UserPromptBox).session;
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
../src/main-window.vala:52.9-52.33: warning:
Gtk.Widget.override_background_color' has been deprecated since 3.16 52 | override_background_color (Gtk.StateFlags.NORMAL, bg_color); | ^~~~~~~~~~~~~~~~~~~~~~~~~ ../src/main-window.vala:54.9-54.23: warning:Gtk.Window.has_resize_grip' has been deprecated since 3.1454 | has_resize_grip = false;
| ^~~~~~~~~~~~~~~
../src/main-window.vala:67.29-67.41: warning:
Gtk.Alignment' has been deprecated since 3.14 67 | var menualign = new Gtk.Alignment (0.0f, 0.0f, 1.0f, 0.0f); | ^~~~~~~~~~~~~ ../src/main-window.vala:67.13-67.21: warning:Gtk.Alignment' has been deprecated since 3.1467 | var menualign = new Gtk.Alignment (0.0f, 0.0f, 1.0f, 0.0f);
| ^~~~~~~~~
../src/main-window.vala:117.25-117.37: warning:
Gtk.Alignment' has been deprecated since 3.14 117 | var align = new Gtk.Alignment (x_align, 0.0f, 0.0f, 1.0f); | ^~~~~~~~~~~~~ ../src/main-window.vala:117.13-117.17: warning:Gtk.Alignment' has been deprecated since 3.14117 | var align = new Gtk.Alignment (x_align, 0.0f, 0.0f, 1.0f);
| ^~~~~
../src/main-window.vala:122.13-122.30: warning:
Gtk.Widget.margin_right' has been deprecated since 3.12 122 | align.margin_right = grid_size; | ^~~~~~~~~~~~~~~~~~ ../src/main-window.vala:133.21-133.33: warning:Gtk.Alignment' has been deprecated since 3.14133 | align = new Gtk.Alignment (0.5f, 0.5f, 0.0f, 0.0f);
| ^~~~~~~~~~~~~
../src/main-window.vala:151.21-151.33: warning:
Gtk.Alignment' has been deprecated since 3.14 151 | align = new Gtk.Alignment (0.0f, 0.5f, 0.0f, 1.0f); | ^~~~~~~~~~~~~ ../src/slick-greeter.vala:552.37-552.91: warning: Access to possiblenull'. Perform a check or use an unsafe cast.552 | unowned X.Display display = (screen.get_display () as Gdk.X11.Display).get_xdisplay ();
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
../src/slick-greeter.vala:553.36-553.73: warning: Access to possible
null'. Perform a check or use an unsafe cast. 553 | unowned X.Screen xscreen = (screen as Gdk.X11.Screen).get_xscreen (); | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ../src/slick-greeter.vala:556.38-556.90: warning: Access to possiblenull'. Perform a check or use an unsafe cast.556 | (screen.get_root_window () as Gdk.X11.Window).get_xid (),
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
../src/slick-greeter.vala:564.46-564.83: warning: Access to possible
null'. Perform a check or use an unsafe cast. 564 | (visual as Gdk.X11.Visual).get_xvisual (), | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ../src/slick-greeter.vala:493.36-493.112: warning: Access to possiblenull'. Perform a check or use an unsafe cast.493 | keyboard_xid = (main_window.menubar.keyboard_window.get_window () as Gdk.X11.Window).get_xid ();
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
../src/slick-greeter.vala:848.38-848.92: warning: Access to possible
null'. Perform a check or use an unsafe cast. 848 | unowned X.Display xdisplay = (screen.get_display () as Gdk.X11.Display).get_xdisplay (); | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ../src/idle-monitor.vala:62.19-62.53: warning: Access to possiblenull'. Perform a check or use an unsafe cast.62 | display = (d as Gdk.X11.Display).get_xdisplay ();
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
../src/dash-box.vala:156.9-156.21: warning: Switch does not handle
NORMAL' of enumDashBox.Mode'156 | switch (mode)
| ^~~~~~~~~~~~~
../src/dash-box.vala:290.17-290.31: warning: unreachable catch clause detected
290 | catch (Error e)
| ^~~~~~~~~~~~~~~
../src/menubar.vala:122.17-122.31: warning: unreachable catch clause detected
122 | catch (Error e)
| ^~~~~~~~~~~~~~~
../src/animate-timer.vala:33.5-33.41: warning: Type `AnimateTimer.EasingFunc' can not be used for a GLib.Object property
33 | public unowned EasingFunc easing_func { get; private set; }
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
Compilation succeeded - 60 warning(s)