feat: infer memberOrganization stint dates from work-email activities (CM-1105)#4054
feat: infer memberOrganization stint dates from work-email activities (CM-1105)#4054
Conversation
There was a problem hiding this comment.
Pull request overview
Adds infrastructure to infer and persist memberOrganizations stint dates from verified work-email activities, so email-domain affiliations become timeline-aware and can compete with enrichment on overlaps.
Changes:
- Extend affiliation resolution to bias toward email-domain rows when a verified email domain is present, and add a source-priority tier in
decidePrimaryOrganizationId. - Buffer
(memberId, orgId, YYYY-MM-DD)activity evidence in Redis on the ingestion hot path and introduce a cron job to infer stint insert/update operations from buffered dates. - Add a partial Postgres index to speed up per-member fetches of
email-domainmemberOrganizations; remove legacy mapping scripts and rename the shared member-organization service file.
Reviewed changes
Copilot reviewed 14 out of 16 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| services/libs/types/src/organizations.ts | Adds shared types for buffered org-dates and inferred stint changes. |
| services/libs/data-access-layer/src/old/apps/data_sink_worker/repo/memberAffiliation.data.ts | Extends work-experience data shape to include source. |
| services/libs/data-access-layer/src/members/segments.ts | Adds optional email-domain candidate inclusion in findMemberWorkExperience. |
| services/libs/data-access-layer/src/members/organizations.ts | Adds fetchMemberOrganizationsBySource for cron’s targeted reads. |
| services/libs/common_services/src/services/memberOrganization.ts | Deleted (renamed). |
| services/libs/common_services/src/services/member/unmerge.ts | Updates import to new member-organization module path. |
| services/libs/common_services/src/services/member-organization.ts | New module: keeps unmerge helpers and adds stint inference logic + Redis key constants. |
| services/libs/common_services/src/services/index.ts | Re-exports renamed member-organization module. |
| services/libs/common_services/src/services/common.member.service.ts | Threads emailDomain through findAffiliation and adds source-priority selection logic. |
| services/apps/data_sink_worker/src/service/member.service.ts | Buffers per-member per-org activity dates in Redis and enqueues member IDs for cron. |
| services/apps/data_sink_worker/src/service/activity.service.ts | Extracts verified email domain from activity payload and passes it into affiliation lookup. |
| services/apps/data_sink_worker/src/bin/map-tenant-members-to-org.ts | Removed outdated script. |
| services/apps/data_sink_worker/src/bin/map-member-to-org.ts | Removed outdated script. |
| services/apps/data_sink_worker/package.json | Removes script entries for deleted bin scripts. |
| services/apps/cron_service/src/jobs/inferMemberOrganizationStintChanges.job.ts | New cron job to drain Redis buffers and compute stint changes (currently dry-run). |
| backend/src/database/migrations/V1776931245__member-organizations-email-domain-partial-index.sql | Adds partial index to support efficient per-member email-domain org reads. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 14 out of 16 changed files in this pull request and generated 5 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 14 out of 16 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 14 out of 16 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 15 out of 17 changed files in this pull request and generated 4 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
d07c84e to
4f9f391
Compare
Signed-off-by: Yeganathan S <63534555+skwowet@users.noreply.github.com>
Signed-off-by: Yeganathan S <63534555+skwowet@users.noreply.github.com>
Signed-off-by: Yeganathan S <63534555+skwowet@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: Yeganathan S <63534555+skwowet@users.noreply.github.com>
Signed-off-by: Yeganathan S <63534555+skwowet@users.noreply.github.com>
…and reuse Signed-off-by: Yeganathan S <63534555+skwowet@users.noreply.github.com>
4f9f391 to
68a79fc
Compare
Signed-off-by: Yeganathan S <63534555+skwowet@users.noreply.github.com>
Signed-off-by: Yeganathan S <63534555+skwowet@users.noreply.github.com>
Signed-off-by: Yeganathan S <63534555+skwowet@users.noreply.github.com>
Signed-off-by: Yeganathan S <63534555+skwowet@users.noreply.github.com>
… in member organization job Signed-off-by: Yeganathan S <63534555+skwowet@users.noreply.github.com>
Signed-off-by: Yeganathan S <63534555+skwowet@users.noreply.github.com>
| "private": true, | ||
| "scripts": { | ||
| "start": "SERVICE=cron-service tsx src/main.ts", | ||
| "start": "SERVICE=cron-service LOG_LEVEL=trace tsx src/main.ts", |
There was a problem hiding this comment.
Remove log level trace here.
There was a problem hiding this comment.
Yeah, added it for debugging during tests. Will remove it after.
| "private": true, | ||
| "scripts": { | ||
| "start": "SERVICE=data-sink-worker tsx src/main.ts", | ||
| "start": "SERVICE=data-sink-worker LOG_LEVEL=trace tsx src/main.ts", |
There was a problem hiding this comment.
Remove log level trace here.
Signed-off-by: Yeganathan S <63534555+skwowet@users.noreply.github.com>
Signed-off-by: Yeganathan S <63534555+skwowet@users.noreply.github.com>
Signed-off-by: Yeganathan S <63534555+skwowet@users.noreply.github.com>
Signed-off-by: Yeganathan S <63534555+skwowet@users.noreply.github.com>
…ation updates Signed-off-by: Yeganathan S <63534555+skwowet@users.noreply.github.com>
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit bdce7d1. Configure here.

Context
When an activity comes in with a verified work email like
jbeulich@suse.com, we already create amemberOrganizationsrow linking the member to SUSE, but with NULLdateStart/dateEnd. That causes two problems:@suse.comactivity can lose to an unrelated dated enrichment row, becausefindAffiliationtreats undated rows as last-resort fallback.We want to use the activity timestamp as evidence that the person was at that company at that moment, and write that into
dateStart/dateEnd. The catch: we can't write on every activity, active maintainers generate hundreds per day, we can't collapse a real multi-stint history like Google -> Apple -> Google into one wrong range, and we can't override user edits or enrichment data.How it works
Hot path (
data_sink_worker): When an activity arrives, we bufferorgId|datein a Redis set keyed by member, and add the member to a pending-members Redis set. This is done with RedisMULTI+SADD, so concurrent data-sink workers can safely write the same member/org/date without lost updates. Hundreds of same-day activities collapse to a single set member.Cron (
cron_service): Every 5 min, the service samples up to 500 pending members, reads each member's buffered set, loads their existing email-domain rows, and walks the buffered dates chronologically applying 4 rules:dateEnd-> extend forward, with a 30-day debounce and a multi-stint guard. If another org holds a 30+ day stint in the gap, insert a fresh stint instead of bridging.dateStart-> extend backward, same multi-stint guard, no debounce. This is mostly for historical re-ingestion.After a member is processed successfully, cron atomically removes only the exact Redis set values it read. If new activity arrives while cron is processing, those new values remain buffered for the next run. If cron fails before acking Redis, the dates stay in Redis and are retried. The ack uses a small Lua script with chunked
SREMcalls to avoid large-argumentunpacklimits.Walking all orgs together in chronological order is what makes multi-stint detection work: by the time the later Google event checks its gap, the Apple stint is already in the working copy and the guard can prevent incorrectly bridging Google -> Apple -> Google into one range.
findAffiliationgets two changes so email-domain rows start contributing meaningfully:ui > email-domain > enrichment-* > other) is added todecidePrimaryOrganizationId. Once email-domain rows have dates, they beat enrichment on overlaps.findMemberWorkExperiencepulls in the matching email-domain row as a candidate even when undated. This is the user-visible win that lands immediately: work-email activities resolve to the right org inline, without waiting for the cron to stamp dates.Partial index on
memberOrganizations("memberId") WHERE source = 'email-domain' AND deletedAt IS NULLbacks the cron's per-member fetch so it's a single index seek.Cleanup
map-member-to-org.ts,map-tenant-members-to-org.ts).memberOrganization.ts->member-organization.tsto match the folder's kebab-case convention.Note
Medium Risk
Medium risk because it changes organization affiliation selection logic and introduces a new Redis-backed cron workflow that writes to
memberOrganizations, which could affect timelines/affiliation attribution and add operational load if mis-tuned.Overview
Adds a Redis-buffered pipeline to infer and persist
memberOrganizations.dateStart/dateEndforemail-domainassociations based on activity timestamps:data_sink_workerbuffers per-memberorgId|dateevidence and a newcron_servicejob periodically applies computed inserts/updates to the DB.Updates affiliation resolution to better respect user intent and source priority: frontend edits now force
memberOrganizations.sourcetoUI, andfindAffiliation/decidePrimaryOrganizationIdprefer higher-priority sources (UI>email-domain>enrichment-*) and can bias toward a verified work-email domain even when the email-domain row is undated.Performance/ops changes include a new partial Postgres index for per-member
email-domainlookups, an atomic RedisackSetMembersLua helper to safely clear processed evidence, and removal of two obsolete data-sink mapping scripts (plus a rename tomember-organization.ts).Reviewed by Cursor Bugbot for commit c2f76de. Bugbot is set up for automated code reviews on this repo. Configure here.