-
Notifications
You must be signed in to change notification settings - Fork 19
Topic/syslog #29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
bhaskarv79
wants to merge
7
commits into
linux-msm:master
Choose a base branch
from
bhaskarv79:topic/syslog
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Topic/syslog #29
Changes from 1 commit
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
0d10a53
tqftpserv: Compilation warnings break strict builds, fix -Wall -Werro…
bhaskarv79 a6b58e3
tqftpserv: Add Syslog-based logging system
bhaskarv79 7696d3f
tqftpserv: Add config file support for tqftpserv runtime configuration
bhaskarv79 eb773fa
tqftpserv: Enable syslog logging in tqftpserv
bhaskarv79 92566eb
tqftpserv: Enable config file support in tqftpserv
bhaskarv79 d2e90ce
tqftpserv: Add sample configuration file for tqftpserv
bhaskarv79 36d7557
tqftpserv: Add config file support for tqftpserv runtime configuration
bhaskarv79 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -7,5 +7,5 @@ cc_binary { | |
| "tqftpserv.c", | ||
| "translate.c", | ||
| ], | ||
| shared_libs: ["libqrtr"], | ||
| shared_libs: ["libqrtr", "libconfig"], | ||
| } | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is the last change in the series. In patch 3 Dmitry suggested that you should use libconfig instead, you said it doesn't work on Android, but here you're adding a dependency on it.
So, commit message doesn't match content, and if this is necessary it clearly can't be the last change in the series - as it would break the build of previous commits.