Make line commit unconditional and remove try_commit_line macro#628
Open
nicoburns wants to merge 2 commits into
Open
Make line commit unconditional and remove try_commit_line macro#628nicoburns wants to merge 2 commits into
nicoburns wants to merge 2 commits into
Conversation
Signed-off-by: Nico Burns <nico@nicoburns.com>
Signed-off-by: Nico Burns <nico@nicoburns.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This refactors and simplifies the line-breaking code.
Changes made:
try_commit_linefunction (it returned aboolas if it was conditional (which historically it used to be), but in reality it was always returnedtrue). Rename it justcommit_lineto reflect this reality.start_new_linecallcommit_lineinternally and remove thetry_commit_linemacro (the macro was to reduce boilerplate which no longer exists if commit_line is called fromstart_new_line).append_cluster_to_lineincrementself.cluster_idx(callers should no longer increment this themselves)append_inline_box_to_lineincrementself.item_idx(callers should no longer increment this themselves)