LCORE-1426: BYOK Config refactoring#1843
Open
are-ces wants to merge 11 commits into
Open
Conversation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Unifies all RAG-related configuration under a single
ragsection inlightspeed-stack.yaml, replacing the three separate top-level sections (byok_rag,rag,okp). Hardcoded chunk limit constants are now user-configurable fields with sensible defaults.Key changes:
byok_raglist →rag.byok.stores(withrag.byok.max_chunks)rag.inline/rag.toollists →rag.retrieval.inline.sources/rag.retrieval.tool.sources(each withmax_chunks)okpsection →rag.okp(withmax_chunks)rag_typefield renamed tobackend(e.g.faissinstead ofinline::faiss)BACKEND_TO_LLAMA_STACK_PROVIDERmapping validates backends during enrichmentBYOK_RAG_MAX_CHUNKS,OKP_RAG_MAX_CHUNKS, etc.) replaced with config defaultsmax_chunksparameter from_fetch_byok_rag(was always passed the config value)_fetch_solr_rag→_fetch_okp_ragfor consistency with the OKP naming conventionType of change
Tools used to create PR
Related Tickets & Documents
Checklist before requesting a review
Testing
uv run make test-unit)uv run make verify)uv run make schema)🤖 Generated with Claude Code
Summary by CodeRabbit
Release Notes
New Features
Documentation
Configuration Changes
backendfield for consistency.