Skip to content

lnwallet/chancloser: use valid delivery scripts in RBF closer tests #11042

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ziggie1984 wants to merge 2 commits into
base: master
Choose a base branch
from
+13 −2
Open

lnwallet/chancloser: use valid delivery scripts in RBF closer tests #11042

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0d5428c
lnwallet/chancloser: use valid delivery scripts in RBF closer tests
ziggie1984 Aug 7, 2026
7cad070
docs: add release notes entry for the RBF closer test fixture fix
ziggie1984 Aug 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions docs/release-notes/release-notes-0.22.0.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -136,6 +136,15 @@

## Testing

* [Fixed an invalid delivery-script fixture in the RBF cooperative close
tests](https://github.com/lightningnetwork/lnd/pull/11042).
`TestRbfChannelActiveTransitions` shadowed the package-level delivery
addresses with byte blobs that are not well-formed shutdown scripts. The
subtests using them all tripped an earlier guard in `validateShutdown`, so the
bad fixture was never reached and nothing failed — but reordering those guards
would have panicked the package's test binary from inside the mock error
reporter, far from the fixture actually at fault.

## Database

## Code Health
Expand Down
6 changes: 4 additions & 2 deletions lnwallet/chancloser/rbf_coop_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,10 @@ import (
"github.com/stretchr/testify/require"
)

// Both of these must stay well-formed delivery scripts (they're P2TR here).
// Tests that drive a shutdown all the way through validateShutdown depend on
// them clearing the delivery-script check, and tests that target an earlier
// guard depend on the script not being what fails.
var (
localAddr = lnwire.DeliveryAddress(append(
[]byte{txscript.OP_1, txscript.OP_DATA_32},
Expand Down Expand Up @@ -1369,8 +1373,6 @@ func testRemoteInitiatedCloseOkTaproot(t *testing.T, ctx context.Context) {
// ChannelActive state.
func TestRbfChannelActiveTransitions(t *testing.T) {
ctx := t.Context()
localAddr := lnwire.DeliveryAddress(bytes.Repeat([]byte{0x01}, 20))
remoteAddr := lnwire.DeliveryAddress(bytes.Repeat([]byte{0x02}, 20))

feeRate := chainfee.SatPerVByte(1000)

Expand Down
Loading