Skip to content

[v0.1.x-branch] Backport #966: waved: fix mailbox-compat test tempdir cleanup flake under -race #975

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Roasbeef merged 1 commit into from
Jul 17, 2026
Merged

[v0.1.x-branch] Backport #966: waved: fix mailbox-compat test tempdir cleanup flake under -race #975

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 17 additions & 2 deletions waved/mailbox_ingress_compat_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,7 +116,17 @@ func TestStartMailboxIngressConcurrentIncompatible(t *testing.T) {
s := newCompatTestServer(t, permanentPullEdge{})

s.runtime.StartEgress()
defer s.runtime.Stop()

// StopAndWait (not the fire-and-forget Stop) so the durable egress
// actor's goroutine has fully exited before the t.Cleanup chain closes
// and removes the shared SQLite DB. Stop only cancels the actor context
// and returns immediately, leaving the egress loop free to keep issuing
// queries against the handle while cleanup runs; an in-flight
// connection re-materializes the WAL/-shm sidecar files, so the tempdir
// RemoveAll then fails with "directory not empty".
defer func() {
require.NoError(t, s.runtime.StopAndWait(t.Context()))
}()

// StartIngress itself succeeds; the ingress goroutine then transitions.
require.NoError(t, s.startMailboxIngress(t.Context()))
Expand All @@ -135,7 +145,12 @@ func TestStartMailboxIngressAlreadyIncompatible(t *testing.T) {
s := newCompatTestServer(t, okPullEdge{})

s.runtime.StartEgress()
defer s.runtime.Stop()

// Drain the durable egress actor before the shared SQLite DB is torn
// down by t.Cleanup; see the note in the concurrent-incompatible test.
defer func() {
require.NoError(t, s.runtime.StopAndWait(t.Context()))
}()

// Mark incompatible up front; the callback clears server_connected.
s.runtime.MarkIncompatible(
Expand Down