Skip to content

tools: bump llformat for variadic call fix - #963

Merged
bhandras merged 1 commit into
mainfrom
codex/bump-llformat-variadic-fix
Jul 16, 2026
Merged

tools: bump llformat for variadic call fix#963
bhandras merged 1 commit into
mainfrom
codex/bump-llformat-variadic-fix

Conversation

@bhandras

Copy link
Copy Markdown
Member

Summary

Audit

  • inspected history for ellipses removed from variadic calls
  • type-checked current calls where a final slice could be passed either as one any value or expanded
  • found no current missing variadic expansions, so this PR contains only the dependency update

Testing

  • make fmt-changed
  • make lint-changed-local
  • make tidy-module-check
  • make commitmsg-lint range="origin/main..HEAD"

Pin the merged formatter revision.

Multiline call reflow now preserves a final variadic ellipsis.
@bhandras
bhandras marked this pull request as ready for review July 16, 2026 14:38

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the dependency github.com/bhandras/llformat in tools/go.mod and tools/go.sum. The review feedback correctly identifies that the newly introduced pseudo-version contains an incorrect future timestamp and base version, and suggests regenerating it using standard Go tooling to ensure dependency resolution correctness.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment thread tools/go.mod
github.com/aymanbagabas/go-osc52/v2 v2.0.1 // indirect
github.com/beorn7/perks v1.0.1 // indirect
github.com/bhandras/llformat v0.1.0-beta // indirect
github.com/bhandras/llformat v0.1.1-beta.0.20260716142411-d42cc6cb46d0 // indirect

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The pseudo-version for llformat appears to be incorrect.

  • The timestamp 20260716... points to a date in the future. The commit d42cc6cb46d0 is from July 2024.
  • The base version v0.1.1-beta does not seem to correspond to an existing tag in the repository. Based on the previous version, the base should likely be v0.1.0-beta.

This can happen due to a misconfigured system clock or an unusual local setup when updating dependencies. To ensure correctness and reproducibility, it's best to use the standard pseudo-version generated by Go tooling.

You can fix this by running go get github.com/bhandras/llformat@d42cc6cb46d0. This will update both go.mod and go.sum with the correct information.

	github.com/bhandras/llformat v0.1.0-beta.0.20240716142411-d42cc6cb46d0 // indirect
References
  1. Go module pseudo-versions should be generated by Go tooling to ensure they accurately reflect the commit's metadata, such as the correct timestamp. Manually constructed or incorrectly generated pseudo-versions can cause confusion and issues with dependency resolution.

@bhandras
bhandras merged commit e3868c9 into main Jul 16, 2026
19 checks passed
@Roasbeef Roasbeef added the backport-v0.1.x-branch Backport this merged PR to v0.1.x-branch label Jul 16, 2026
@github-actions

Copy link
Copy Markdown

Successfully created backport PR for v0.1.x-branch:

Roasbeef added a commit that referenced this pull request Jul 17, 2026
[v0.1.x-branch] Backport #963: tools: bump llformat for variadic call fix
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport-v0.1.x-branch Backport this merged PR to v0.1.x-branch

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants