tools: bump llformat for variadic call fix - #963
Conversation
Pin the merged formatter revision. Multiline call reflow now preserves a final variadic ellipsis.
There was a problem hiding this comment.
Code Review
This pull request updates the dependency github.com/bhandras/llformat in tools/go.mod and tools/go.sum. The review feedback correctly identifies that the newly introduced pseudo-version contains an incorrect future timestamp and base version, and suggests regenerating it using standard Go tooling to ensure dependency resolution correctness.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
| github.com/aymanbagabas/go-osc52/v2 v2.0.1 // indirect | ||
| github.com/beorn7/perks v1.0.1 // indirect | ||
| github.com/bhandras/llformat v0.1.0-beta // indirect | ||
| github.com/bhandras/llformat v0.1.1-beta.0.20260716142411-d42cc6cb46d0 // indirect |
There was a problem hiding this comment.
The pseudo-version for llformat appears to be incorrect.
- The timestamp
20260716...points to a date in the future. The commitd42cc6cb46d0is from July 2024. - The base version
v0.1.1-betadoes not seem to correspond to an existing tag in the repository. Based on the previous version, the base should likely bev0.1.0-beta.
This can happen due to a misconfigured system clock or an unusual local setup when updating dependencies. To ensure correctness and reproducibility, it's best to use the standard pseudo-version generated by Go tooling.
You can fix this by running go get github.com/bhandras/llformat@d42cc6cb46d0. This will update both go.mod and go.sum with the correct information.
github.com/bhandras/llformat v0.1.0-beta.0.20240716142411-d42cc6cb46d0 // indirect
References
- Go module pseudo-versions should be generated by Go tooling to ensure they accurately reflect the commit's metadata, such as the correct timestamp. Manually constructed or incorrectly generated pseudo-versions can cause confusion and issues with dependency resolution.
|
Successfully created backport PR for |
[v0.1.x-branch] Backport #963: tools: bump llformat for variadic call fix
Summary
Audit
anyvalue or expandedTesting
make fmt-changedmake lint-changed-localmake tidy-module-checkmake commitmsg-lint range="origin/main..HEAD"