tree: add asset-aware materialization context - #1176
Open
darioAnongba wants to merge 1 commit into
Open
Conversation
This was referenced Aug 21, 2026
darioAnongba
commented
Aug 24, 2026
Asset-bearing tree nodes use distinct taproot tweaks and carry units independently from carrier satoshis. Store this data in an outpoint-keyed context so extracted paths sign deterministically without changing Bitcoin-only trees. Keep per-node tweak selection inside Tree signing and retain the existing public signer API. Copy MuSig2 participant slices before aggregation because the local signer may sort caller-owned state.
darioAnongba
force-pushed
the
darioAnongba/assets-tree-foundation
branch
from
August 24, 2026 10:23
3f0375b to
75de4e8
Compare
darioAnongba
marked this pull request as ready for review
August 24, 2026 11:15
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 75de4e829a
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Member
|
Hey! Great work, currently reviewing this (side by side with #1177 ) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Runtime isolation
This branch adds no asset runtime entry point. Bitcoin-only leaves keep
AssetAmountat zero,BuildStructurereturns a nilAssetContext, and public signer calls continue to use the tree-wide sweep tweak.