Skip to content

Support async signing of splice shared input #4579

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wpaulino wants to merge 1 commit into
base: main
Choose a base branch
from

Support async signing of splice shared input

9df5f83
Select commit
Loading
Failed to load commit list.
Open

Support async signing of splice shared input #4579

Support async signing of splice shared input
9df5f83
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Apr 29, 2026 in 0s

87.15% (-0.01%) compared to 42e198c

View this Pull Request on Codecov

87.15% (-0.01%) compared to 42e198c

Details

Codecov Report

❌ Patch coverage is 95.21277% with 9 lines in your changes missing coverage. Please review.
✅ Project coverage is 87.15%. Comparing base (42e198c) to head (9df5f83).

Files with missing lines Patch % Lines
lightning/src/ln/interactivetxs.rs 86.84% 4 Missing and 1 partial ⚠️
lightning/src/ln/channel.rs 97.59% 1 Missing and 1 partial ⚠️
lightning/src/ln/channelmanager.rs 98.33% 0 Missing and 1 partial ⚠️
lightning/src/util/test_channel_signer.rs 80.00% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #4579      +/-   ##
==========================================
- Coverage   87.15%   87.15%   -0.01%     
==========================================
  Files         161      161              
  Lines      109251   109394     +143     
  Branches   109251   109394     +143     
==========================================
+ Hits        95215    95337     +122     
- Misses      11560    11580      +20     
- Partials     2476     2477       +1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
View more details on Codecov