Skip to content

Don't trim HTLCs when calculating the commit tx fee including the fee spike multiple #4574

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
tankyleo wants to merge 11 commits into
base: main
Choose a base branch
from

Test the fee spike buffer multiple affordability check

059fb46
Select commit
Loading
Failed to load commit list.
Draft

Don't trim HTLCs when calculating the commit tx fee including the fee spike multiple #4574

Test the fee spike buffer multiple affordability check
059fb46
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Apr 24, 2026 in 1s

87.11% (+0.04%) compared to 3278ece

View this Pull Request on Codecov

87.11% (+0.04%) compared to 3278ece

Details

Codecov Report

❌ Patch coverage is 94.57831% with 18 lines in your changes missing coverage. Please review.
✅ Project coverage is 87.11%. Comparing base (3278ece) to head (059fb46).
⚠️ Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
lightning/src/ln/channel.rs 91.97% 10 Missing and 5 partials ⚠️
lightning/src/ln/channel_state.rs 66.66% 1 Missing ⚠️
lightning/src/ln/channelmanager.rs 0.00% 1 Missing ⚠️
lightning/src/routing/router.rs 50.00% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #4574      +/-   ##
==========================================
+ Coverage   87.07%   87.11%   +0.04%     
==========================================
  Files         161      161              
  Lines      109248   109323      +75     
  Branches   109248   109323      +75     
==========================================
+ Hits        95127    95239     +112     
+ Misses      11640    11602      -38     
- Partials     2481     2482       +1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
View more details on Codecov