Skip to content

Add AvailableBalances::next_splice_out_maximum_sat #4550

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
tankyleo wants to merge 6 commits into
base: main
Choose a base branch
from

Always enforce the 1000sat min channel value in zero-reserve channels

89ee5a1
Select commit
Loading
Failed to load commit list.
Open

Add AvailableBalances::next_splice_out_maximum_sat #4550

Always enforce the 1000sat min channel value in zero-reserve channels
89ee5a1
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Apr 29, 2026 in 1s

87.15% (+0.00%) compared to 42e198c

View this Pull Request on Codecov

87.15% (+0.00%) compared to 42e198c

Details

Codecov Report

❌ Patch coverage is 92.70833% with 21 lines in your changes missing coverage. Please review.
✅ Project coverage is 87.15%. Comparing base (42e198c) to head (89ee5a1).

Files with missing lines Patch % Lines
lightning/src/ln/channel.rs 89.88% 13 Missing and 5 partials ⚠️
lightning/src/ln/channel_state.rs 66.66% 1 Missing ⚠️
lightning/src/ln/channelmanager.rs 50.00% 1 Missing ⚠️
lightning/src/routing/router.rs 50.00% 1 Missing ⚠️
Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #4550   +/-   ##
=======================================
  Coverage   87.15%   87.15%           
=======================================
  Files         161      161           
  Lines      109251   109318   +67     
  Branches   109251   109318   +67     
=======================================
+ Hits        95215    95274   +59     
- Misses      11560    11569    +9     
+ Partials     2476     2475    -1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
View more details on Codecov