Skip to content

Include failure context in splice events #4514

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jkczyz wants to merge 12 commits into
base: main
Choose a base branch
from

Derive DiscardFunding inputs and outputs from contributions on promotion

678bbc4
Select commit
Loading
Failed to load commit list.
Open

Include failure context in splice events #4514

Derive DiscardFunding inputs and outputs from contributions on promotion
678bbc4
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Apr 28, 2026 in 0s

87.14% (-0.02%) compared to 42e198c

View this Pull Request on Codecov

87.14% (-0.02%) compared to 42e198c

Details

Codecov Report

❌ Patch coverage is 86.04651% with 36 lines in your changes missing coverage. Please review.
✅ Project coverage is 87.14%. Comparing base (42e198c) to head (678bbc4).

Files with missing lines Patch % Lines
lightning/src/events/mod.rs 25.00% 18 Missing ⚠️
lightning/src/ln/channelmanager.rs 90.98% 5 Missing and 6 partials ⚠️
lightning/src/ln/channel.rs 96.90% 2 Missing and 1 partial ⚠️
lightning/src/ln/funding.rs 40.00% 3 Missing ⚠️
lightning/src/ln/functional_test_utils.rs 90.00% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #4514      +/-   ##
==========================================
- Coverage   87.15%   87.14%   -0.02%     
==========================================
  Files         161      160       -1     
  Lines      109251   109208      -43     
  Branches   109251   109208      -43     
==========================================
- Hits        95215    95164      -51     
- Misses      11560    11566       +6     
- Partials     2476     2478       +2

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
View more details on Codecov