Skip to content

Use BestBlock for chain state serialization (and somewhat parallelize init) #4266

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
TheBlueMatt merged 13 commits into from
Mar 30, 2026

Include recent blocks in the `synchronize_listeners`-returned cache

74e1da3
Select commit
Loading
Failed to load commit list.
Merged

Use BestBlock for chain state serialization (and somewhat parallelize init) #4266

Include recent blocks in the `synchronize_listeners`-returned cache
74e1da3
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Mar 30, 2026 in 0s

86.20% (+0.00%) compared to b3a99f6

View this Pull Request on Codecov

86.20% (+0.00%) compared to b3a99f6

Details

Codecov Report

❌ Patch coverage is 92.77108% with 24 lines in your changes missing coverage. Please review.
✅ Project coverage is 86.20%. Comparing base (b3a99f6) to head (74e1da3).
⚠️ Report is 30 commits behind head on main.

Files with missing lines Patch % Lines
lightning/src/util/persist.rs 66.66% 5 Missing and 1 partial ⚠️
lightning-block-sync/src/init.rs 94.11% 3 Missing and 2 partials ⚠️
lightning-block-sync/src/lib.rs 93.90% 4 Missing and 1 partial ⚠️
lightning/src/ln/channelmanager.rs 83.33% 3 Missing ⚠️
lightning/src/util/ser.rs 81.25% 0 Missing and 3 partials ⚠️
lightning/src/chain/channelmonitor.rs 88.88% 0 Missing and 1 partial ⚠️
lightning/src/chain/mod.rs 98.59% 0 Missing and 1 partial ⚠️
Additional details and impacted files 
@@            Coverage Diff            @@
##             main    #4266     +/-   ##
=========================================
  Coverage   86.19%   86.20%             
=========================================
  Files         160      161      +1     
  Lines      107537   108611   +1074     
  Branches   107537   108611   +1074     
=========================================
+ Hits        92693    93627    +934     
- Misses      12218    12347    +129     
- Partials     2626     2637     +11

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
View more details on Codecov