-
Notifications
You must be signed in to change notification settings - Fork 342
Remove API client from LightlySSL #1939
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
gabrielfruet
wants to merge
11
commits into
master
Choose a base branch
from
gabriel-trn-1734-remove-api-client-from-lightlyssl
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
29667a3
refactor!: remove lightly.api, lightly.openapi_generated, lightly.act…
gabrielfruet 5ee5e0e
feat(cli)!: remove lightly-download and lightly-serve
gabrielfruet ef2db53
refactor: drop API-only dependencies and tooling config
gabrielfruet 5cb59d4
test: drop api_workflow tests and mocks
gabrielfruet 4829325
ci: drop api-deps-only workflow and version-check env vars
gabrielfruet b5e54e7
docs: remove API client documentation
gabrielfruet 87a34cb
test: remove stale token override
gabrielfruet 1ad554f
Merge branch 'master' into gabriel-trn-1734-remove-api-client-from-li…
gabrielfruet bff474f
Merge branch 'master' into gabriel-trn-1734-remove-api-client-from-li…
gabrielfruet 59ab2d6
fix: add deprecated api import error
gabrielfruet f06dd3e
docs: point README to LightlyStudio per review (#1939)
gabrielfruet File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -103,7 +103,6 @@ Lightly AI | |
| :caption: Python API | ||
|
|
||
| lightly | ||
| lightly.api | ||
| lightly.cli | ||
| lightly.core | ||
| lightly.data | ||
|
|
||
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,15 +1,13 @@ | ||
| """The lightly.api module provides access to the Lightly API.""" | ||
| """Deprecated compatibility module for the removed Lightly API client.""" | ||
|
|
||
| # Copyright (c) 2020. Lightly AG and its affiliates. | ||
| # All Rights Reserved | ||
| from lightly.api import patch as _patch | ||
| from lightly.api.api_workflow_artifacts import ArtifactNotExist | ||
| from lightly.api.api_workflow_client import ApiWorkflowClient | ||
| from lightly.openapi_generated.swagger_client.api_client import ( | ||
| Configuration as _Configuration, | ||
| ) | ||
|
|
||
| # Make ApiWorkflowClient and swagger classes picklable. | ||
| _patch.make_swagger_configuration_picklable( | ||
| configuration_cls=_Configuration, | ||
| _ERROR_MESSAGE = ( | ||
| "lightly.api and ApiWorkflowClient have been removed from the lightly package. " | ||
| "The API workflow client is deprecated. If you need ApiWorkflowClient, use " | ||
| "Lightly SSL version v1.15.x or older, for example with " | ||
| '`pip install "lightly<1.16"`.' | ||
| ) | ||
|
|
||
| raise ImportError(_ERROR_MESSAGE) | ||
|
MalteEbner marked this conversation as resolved.
|
||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No need to repeat the previous sentence in other words