-
Notifications
You must be signed in to change notification settings - Fork 33
Analytics: track annotation source and label filter toggles with grid_filter_toggled
#1766
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
LeonardoRosaa
wants to merge
2
commits into
main
Choose a base branch
from
leonardo-lig-10227-analytics-track-workflows-filter-grid-view-toggled
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
108 changes: 108 additions & 0 deletions
108
...w/src/lib/components/AnnotationCollectionsMenu/handleAnnotationSourceFilterChange.test.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,108 @@ | ||
| import { describe, expect, it, vi } from 'vitest'; | ||
| import { handleAnnotationSourceFilterChange } from './handleAnnotationSourceFilterChange'; | ||
|
|
||
| const items = [ | ||
| { id: 'c1', name: 'Dogs' }, | ||
| { id: 'c2', name: 'Cats' } | ||
| ]; | ||
|
|
||
| describe('handleAnnotationSourceFilterChange', () => { | ||
| it('calls setSelectedCollectionIds with the new ids', () => { | ||
| const setSelectedCollectionIds = vi.fn(); | ||
| const trackEvent = vi.fn(); | ||
|
|
||
| handleAnnotationSourceFilterChange({ | ||
| newIds: ['c2'], | ||
| prevIds: ['c1', 'c2'], | ||
| items, | ||
| collectionId: 'col-1', | ||
| setSelectedCollectionIds, | ||
| trackEvent | ||
| }); | ||
|
|
||
| expect(setSelectedCollectionIds).toHaveBeenCalledWith(['c2']); | ||
| }); | ||
|
|
||
| it('fires grid_filter_toggled with action unselected when a source is deselected', () => { | ||
| const setSelectedCollectionIds = vi.fn(); | ||
| const trackEvent = vi.fn(); | ||
|
|
||
| handleAnnotationSourceFilterChange({ | ||
| newIds: ['c2'], | ||
| prevIds: ['c1', 'c2'], | ||
| items, | ||
| collectionId: 'col-1', | ||
| setSelectedCollectionIds, | ||
| trackEvent | ||
| }); | ||
|
|
||
| expect(trackEvent).toHaveBeenCalledWith('grid_filter_toggled', { | ||
| collection_id: 'col-1', | ||
| filter_type: 'annotation_source', | ||
| filter_value: 'Dogs', | ||
| action: 'unselected', | ||
| active_count: 1 | ||
| }); | ||
| }); | ||
|
|
||
| it('fires grid_filter_toggled with action selected when a source is selected', () => { | ||
| const setSelectedCollectionIds = vi.fn(); | ||
| const trackEvent = vi.fn(); | ||
|
|
||
| handleAnnotationSourceFilterChange({ | ||
| newIds: ['c1', 'c2'], | ||
| prevIds: ['c2'], | ||
| items, | ||
| collectionId: 'col-1', | ||
| setSelectedCollectionIds, | ||
| trackEvent | ||
| }); | ||
|
|
||
| expect(trackEvent).toHaveBeenCalledWith('grid_filter_toggled', { | ||
| collection_id: 'col-1', | ||
| filter_type: 'annotation_source', | ||
| filter_value: 'Dogs', | ||
| action: 'selected', | ||
| active_count: 2 | ||
| }); | ||
| }); | ||
|
|
||
| it('does not fire trackEvent when the changed id is not found in items', () => { | ||
| const setSelectedCollectionIds = vi.fn(); | ||
| const trackEvent = vi.fn(); | ||
|
|
||
| handleAnnotationSourceFilterChange({ | ||
| newIds: ['c2'], | ||
| prevIds: ['unknown', 'c2'], | ||
| items, | ||
| collectionId: 'col-1', | ||
| setSelectedCollectionIds, | ||
| trackEvent | ||
| }); | ||
|
|
||
| expect(setSelectedCollectionIds).toHaveBeenCalledWith(['c2']); | ||
| expect(trackEvent).not.toHaveBeenCalled(); | ||
| }); | ||
|
|
||
| it('reports active_count as the length of newIds', () => { | ||
| const setSelectedCollectionIds = vi.fn(); | ||
| const trackEvent = vi.fn(); | ||
|
|
||
| handleAnnotationSourceFilterChange({ | ||
| newIds: [], | ||
| prevIds: ['c1'], | ||
| items, | ||
| collectionId: 'col-1', | ||
| setSelectedCollectionIds, | ||
| trackEvent | ||
| }); | ||
|
|
||
| expect(trackEvent).toHaveBeenCalledWith('grid_filter_toggled', { | ||
| collection_id: 'col-1', | ||
| filter_type: 'annotation_source', | ||
| filter_value: 'Dogs', | ||
| action: 'unselected', | ||
| active_count: 0 | ||
| }); | ||
| }); | ||
| }); |
45 changes: 45 additions & 0 deletions
45
...o_view/src/lib/components/AnnotationCollectionsMenu/handleAnnotationSourceFilterChange.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,45 @@ | ||
| interface HandleAnnotationSourceFilterChangeParams { | ||
| /** The new set of selected collection IDs after the user's action. */ | ||
| newIds: string[]; | ||
| /** The set of selected collection IDs before the user's action. */ | ||
| prevIds: string[]; | ||
| /** All available annotation source items with their display names. */ | ||
| items: { id: string; name: string }[]; | ||
| /** The active dataset collection ID, used as context in the analytics event. */ | ||
| collectionId: string; | ||
| /** Updates the persisted selection of annotation source IDs. */ | ||
| setSelectedCollectionIds: (ids: string[]) => void; | ||
| /** Fires an analytics event. */ | ||
| trackEvent: (eventName: string, properties?: Record<string, unknown>) => void; | ||
| } | ||
|
|
||
| export function handleAnnotationSourceFilterChange({ | ||
| newIds, | ||
| prevIds, | ||
| items, | ||
| collectionId, | ||
| setSelectedCollectionIds, | ||
| trackEvent | ||
| }: HandleAnnotationSourceFilterChangeParams): void { | ||
| const prevSet = new Set(prevIds); | ||
| const nextSet = new Set(newIds); | ||
|
|
||
| const addedId = newIds.find((id) => !prevSet.has(id)); | ||
| const removedId = prevIds.find((id) => !nextSet.has(id)); | ||
|
|
||
| const action: 'selected' | 'unselected' = addedId ? 'selected' : 'unselected'; | ||
| const changedId = addedId ?? removedId; | ||
| const changedItem = items.find((item) => item.id === changedId); | ||
|
|
||
| setSelectedCollectionIds(newIds); | ||
|
|
||
| if (changedItem) { | ||
| trackEvent('grid_filter_toggled', { | ||
| collection_id: collectionId, | ||
| filter_type: 'annotation_source', | ||
| filter_value: changedItem.name, | ||
| action, | ||
| active_count: newIds.length | ||
| }); | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.