Extract EmbeddingResult to a shared, path-agnostic module#1710
Open
JonasWurst wants to merge 1 commit into
Open
Extract EmbeddingResult to a shared, path-agnostic module#1710JonasWurst wants to merge 1 commit into
JonasWurst wants to merge 1 commit into
Conversation
Rename ImageEmbeddingResult -> EmbeddingResult and move it out of image_embedding.py into its own dependency-free module (dataset/embedding_result.py). The type carries embeddings plus kept_indices and is not image-specific; giving it a neutral home lets the image, image-crop, and (future) video embedding paths reuse it without importing a path-specific module. Pure rename/move: no behavior change. All references and docstrings updated. Only the image embedding path is touched here; the crop path still returns NDArray on main and adopts EmbeddingResult in the stacked crop PR. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (7)
📝 WalkthroughWalkthroughAdds a shared frozen ChangesEmbedding result standardization
Estimated code review effort: 3 (Moderate) | ~20 minutes Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
❌ Fast Track: checks did not passFailed guardrails: backend/complexity (Guardrail threw: spawn uv ENOENT), backend/coverage (Guardrail threw: spawn uv ENOENT)
Reflects |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: d2f988d9c4
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
JonasWurst
added a commit
that referenced
this pull request
Jul 22, 2026
Apply the per-item broken-file handling from the full-image embedding path (#1691) to the crop path, on top of the shared EmbeddingResult foundation (#1710). - embed_image_crops_batched catches (OSError, UnidentifiedImageError) per source file; a broken/undecodable file skips all of its crops instead of aborting the run, and is recorded once as BROKEN in a FileOutcomeReport. Returns an EmbeddingResult carrying kept_indices (input positions of the embedded crops) and raises AllInputFilesFailedError when every source file is broken. - Propagate EmbeddingResult through the ImageEmbeddingGenerator protocol embed_image_crops and its implementations (mobileclip, perception_encoder, RandomEmbeddingGenerator, custom-model example). - embedding_manager.embed_annotations filters annotation sample IDs by kept_indices before storing, keeping sample IDs and embeddings in sync. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Contributor
Author
|
/review |
michal-lightly
approved these changes
Jul 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Prefactor sliced out of #1706. Pure rename/move — no behavior change.
ImageEmbeddingResult→EmbeddingResultand move it out ofimage_embedding.pyinto its own dependency-free moduledataset/embedding_result.py.embeddings+kept_indicesand is not image-specific. Giving it a neutral home lets the image, image-crop, and (future) video embedding paths reuse it without importing a path-specific module.NDArrayonmainand adoptsEmbeddingResultin the stacked crop PR (Tolerate broken files per-item in image crop embedding #1706).Stacking
#1706 (crop broken-file handling) will be rebased to stack on top of this PR.
Testing
make static-checks— ruff + format + mypy clean.pytest tests/dataset/{test_embedding_manager,test_mobileclip_embedding_generator,test_perception_encoder_embedding_generator,test_embedding_generator}.py— 46 passed.🤖 Generated with Claude Code
Summary by CodeRabbit