Skip to content

LIG-10239 Wire sample-tag distribution comparison#1695

Draft
ikondrat wants to merge 1 commit into
kondrat-lig-10246-frontend-sample-tag-comparison-multi-select-controlfrom
kondrat-lig-10239-frontend-sample-tag-comparison-selection-and-query-wiring
Draft

LIG-10239 Wire sample-tag distribution comparison#1695
ikondrat wants to merge 1 commit into
kondrat-lig-10246-frontend-sample-tag-comparison-multi-select-controlfrom
kondrat-lig-10239-frontend-sample-tag-comparison-selection-and-query-wiring

Conversation

@ikondrat

Copy link
Copy Markdown
Contributor

Summary

  • load sample tags for the active image dataset without reusing the grid's selected-tag state
  • keep a local, ordered comparison selection and prune IDs that are no longer available
  • issue grouped class-count requests for All types, Classification, Object detection, and Segmentation
  • apply the complete active image filter and current annotation count mode to every grouped request
  • attach grouped responses to the matching distribution source/group for chart rendering

Stack

Testing instructions

  1. Check out this branch with the preceding stacked PRs.
  2. Generate the local API client if it is not already present:
    cd lightly_studio_view
    npm run generate-api-client
  3. Run:
    make static-checks
  4. Open an image collection with sample tags and the Distribution panel.
  5. Select multiple tags in Compare by and verify grouped count requests are sent for the current All types / annotation-type scopes.
  6. Toggle filters and count mode, then verify the grouped requests update while the dataset grid's active tag filter remains unchanged.
  7. Clear the comparison selection and verify grouped requests are disabled and the overall distribution remains available.

Validation

  • make static-checks (Node 24.13.1): passed

@coderabbitai

coderabbitai Bot commented Jul 21, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 9e547501-c61c-44df-88da-8290042b46aa

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch kondrat-lig-10239-frontend-sample-tag-comparison-selection-and-query-wiring

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant