Skip to content

Wire event bar into VideoPlayer, VideoControls and VideoDetails#1673

Merged
LeonardoRosaa merged 39 commits into
mainfrom
horatiu-lig-9807-show-event-bars-on-the-timeline-3-events-wiring
Jul 21, 2026
Merged

Wire event bar into VideoPlayer, VideoControls and VideoDetails#1673
LeonardoRosaa merged 39 commits into
mainfrom
horatiu-lig-9807-show-event-bars-on-the-timeline-3-events-wiring

Conversation

@horatiualmasan

@horatiualmasan horatiualmasan commented Jul 16, 2026

Copy link
Copy Markdown
Contributor

What has changed and why?

Wires the event bar into the real player. VideoControls gains a children snippet rendered below the transport buttons, sharing the scrubber's padded, full-width coordinate system so bars line up with the scrubber. VideoPlayer accepts events and durationS props and renders VideoEventTimeline inside the controls (headerless), preferring an explicit duration so the scrubber and bars agree before metadata loads. VideoDetails derives events from the sample's annotations and passes them down. No event bar renders when there are no events.

How has it been tested?

Added VideoPlayer tests and stories covering the events/duration props and event-bar rendering. Manually verified on a video sample with imported ActivityNet-style events that bars appear, align with the scrubber, and seek on click.
Run example_activitynet.py to test locally
image

Did you update CHANGELOG.md?

  • Yes
  • Not needed (internal change)

Summary by CodeRabbit

  • New Features

    • Added support for displaying time-aligned events and labels on the video timeline.
    • Added optional duration support to improve timeline positioning.
    • Enabled additional content below video controls.
  • Bug Fixes

    • Improved synchronization between the video scrubber and event timeline.
  • Tests

    • Added coverage for event timeline visibility and label rendering.

horatiualmasan and others added 30 commits July 7, 2026 17:54
…ions' into horatiu-lig-9805-import-activitynet-style-event-annotations-3
Previously, filtering and counting video annotations only considered
annotations attached to a video's frames. Videos can also carry
annotations directly (e.g. ActivityNet-style event/classification labels
on the whole video). This makes both the video filter and the annotation
counter consider these direct video annotations in addition to frame
annotations.
…ions-3' into horatiu-lig-9806-filter-videos-by-event-metadata
Mirrors a <video> element's playback state into reactive fields and
exposes intent callbacks (seek, play/pause, mute, fullscreen) for a
custom control bar. Listening via native events keeps it composable
with handlers on the element. Covered by a harness-driven unit test.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Compose useVideoPlayback + VideoControls, forcing native <video controls>
off so the full-width scrubber can host aligned timeline overlays. Adds a
startTimeS prop (null waits for a deep-link timestamp) and a region ref
for fullscreen. Updates tests and stories accordingly.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Hand the deep-linked frame's timestamp to VideoPlayer via startTimeS
instead of seeking after load, and remount on frame-number change with
a composite #key. Align the annotation overlay to the <video> box and
fix min-h-0 layout so the player fills its card. Adds a VideoDetails
test covering the frame-load branch and deep-link handoff.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Full-width scrubber + transport buttons that own no playback state and
call back on user intent. Includes helpers (formatTime, clampPercent,
timeFromClientX) and unit tests. Exported from the components barrel.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Interactive Playground plus paused / near-end states, on a dark backdrop
matching how the bar overlays a video.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Mirrors a <video> element's playback state into reactive fields and
exposes intent callbacks (seek, play/pause, mute, fullscreen) for a
custom control bar. Listening via native events keeps it composable
with handlers on the element. Covered by a harness-driven unit test.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Compose useVideoPlayback + VideoControls, forcing native <video controls>
off so the full-width scrubber can host aligned timeline overlays. Adds a
startTimeS prop (null waits for a deep-link timestamp) and a region ref
for fullscreen. Updates tests and stories accordingly.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Hand the deep-linked frame's timestamp to VideoPlayer via startTimeS
instead of seeking after load, and remount on frame-number change with
a composite #key. Align the annotation overlay to the <video> box and
fix min-h-0 layout so the player fills its card. Adds a VideoDetails
test covering the frame-load branch and deep-link handoff.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
…github.com:lightly-ai/lightly-studio into horatiu-lig-9807-show-event-bars-on-the-timeline.d
horatiualmasan and others added 3 commits July 16, 2026 23:49
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
@horatiualmasan
horatiualmasan requested a review from a team as a code owner July 16, 2026 21:04
@coderabbitai

coderabbitai Bot commented Jul 16, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 5441d12c-8d38-4083-b93e-96975e52d41e

📥 Commits

Reviewing files that changed from the base of the PR and between 3856273 and f212218.

📒 Files selected for processing (5)
  • lightly_studio_view/src/lib/components/VideoControls/VideoControls.svelte
  • lightly_studio_view/src/lib/components/VideoDetails/VideoDetails.svelte
  • lightly_studio_view/src/lib/components/VideoPlayer/VideoPlayer.stories.svelte
  • lightly_studio_view/src/lib/components/VideoPlayer/VideoPlayer.svelte
  • lightly_studio_view/src/lib/components/VideoPlayer/VideoPlayer.test.ts

📝 Walkthrough

Walkthrough

VideoPlayer now accepts video events and explicit duration values, renders an aligned event timeline, and passes shared duration data to its controls. VideoDetails supplies transformed annotations, while stories and tests cover event rendering.

Changes

Video event timeline

Layer / File(s) Summary
Controls content extension
lightly_studio_view/src/lib/components/VideoControls/VideoControls.svelte
VideoControls accepts an optional Svelte Snippet and renders it below the transport controls.
Player event timeline
lightly_studio_view/src/lib/components/VideoPlayer/VideoPlayer.svelte
VideoPlayer accepts events and durationS, derives an effective duration, and conditionally renders the event timeline using the shared coordinate system.
Event data wiring and validation
lightly_studio_view/src/lib/components/VideoDetails/VideoDetails.svelte, lightly_studio_view/src/lib/components/VideoPlayer/VideoPlayer.stories.svelte, lightly_studio_view/src/lib/components/VideoPlayer/VideoPlayer.test.ts
Video annotations are transformed into events, an event-enabled Storybook scenario is added, and tests cover timeline visibility and event labels.

Estimated code review effort: 3 (Moderate) | ~20 minutes

Sequence Diagram(s)

sequenceDiagram
  participant VideoDetails
  participant VideoPlayer
  participant VideoControls
  participant VideoEventTimeline
  VideoDetails->>VideoPlayer: events and durationS
  VideoPlayer->>VideoControls: effectiveDurationS
  VideoPlayer->>VideoEventTimeline: events and effectiveDurationS
Loading

Possibly related PRs

Suggested reviewers: leonardorosaa

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly summarizes the main change: wiring the event bar into the video player and related components.
Description check ✅ Passed The description follows the template with clear change summary, testing notes, and changelog status.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch horatiu-lig-9807-show-event-bars-on-the-timeline-3-events-wiring

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

horatiualmasan and others added 5 commits July 17, 2026 10:11
…ts-model' into horatiu-lig-9807-show-event-bars-on-the-timeline-3-events-timeline
…ts-timeline' into horatiu-lig-9807-show-event-bars-on-the-timeline-3-events-wiring
…ts-wiring' of github.com:lightly-ai/lightly-studio into horatiu-lig-9807-show-event-bars-on-the-timeline-3-events-wiring
@horatiualmasan

Copy link
Copy Markdown
Contributor Author

/review

Base automatically changed from horatiu-lig-9807-show-event-bars-on-the-timeline-3-events-timeline to main July 21, 2026 15:35
@LeonardoRosaa
LeonardoRosaa enabled auto-merge July 21, 2026 16:14
@LeonardoRosaa
LeonardoRosaa added this pull request to the merge queue Jul 21, 2026
Merged via the queue into main with commit 6b59d02 Jul 21, 2026
22 checks passed
@LeonardoRosaa
LeonardoRosaa deleted the horatiu-lig-9807-show-event-bars-on-the-timeline-3-events-wiring branch July 21, 2026 16:44
@coderabbitai coderabbitai Bot mentioned this pull request Jul 21, 2026
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants