Skip to content

Add CIMRepository open coverage and align _FormatFilenameAsGlob call sites with its return value #37

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
kev365 wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Add CIMRepository open coverage and align _FormatFilenameAsGlob call sites with its return value #37

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ccd2295
Add CIMRepository open coverage and align _FormatFilenameAsGlob call …
kev365 Aug 12, 2026
1a44b9c
Applied black formatting to the added test
kev365 Aug 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions dtformats/wmi_repository.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3492,7 +3492,7 @@ def _GetActiveMappingFile(self, path):
# Unsure how reliable this method is since multiple index[1-3].map files
# can have the same sequence number but contain different mappings.
for mapping_file_number in range(1, 4):
filename_as_glob, _ = self._FormatFilenameAsGlob(
filename_as_glob = self._FormatFilenameAsGlob(
f"mapping{mapping_file_number:d}.map"
)
path_with_glob = self._file_system_helper.JoinPath([path, filename_as_glob])
Expand Down Expand Up @@ -3851,7 +3851,7 @@ def _OpenIndexBinaryTreeFile(self, path):
Returns:
IndexBinaryTreeFile: index binary tree file or None if not available.
"""
filename_as_glob, _ = self._FormatFilenameAsGlob("index.btr")
filename_as_glob = self._FormatFilenameAsGlob("index.btr")
index_binary_tree_file_glob = self._file_system_helper.JoinPath(
[path, filename_as_glob]
)
Expand Down Expand Up @@ -3880,7 +3880,7 @@ def _OpenMappingFile(self, path, filename):
Returns:
MappingFile: mapping file or None if not available.
"""
filename_as_glob, _ = self._FormatFilenameAsGlob(filename)
filename_as_glob = self._FormatFilenameAsGlob(filename)
mapping_file_glob = self._file_system_helper.JoinPath([path, filename_as_glob])

mapping_file_path = glob.glob(mapping_file_glob)
Expand All @@ -3904,7 +3904,7 @@ def _OpenMappingVersionFile(self, path):
Returns:
file: file-like object or None if not available.
"""
filename_as_glob, _ = self._FormatFilenameAsGlob("mapping.ver")
filename_as_glob = self._FormatFilenameAsGlob("mapping.ver")
mapping_version_file_glob = self._file_system_helper.JoinPath(
[path, filename_as_glob]
)
Expand All @@ -3925,7 +3925,7 @@ def _OpenObjectsDataFile(self, path):
Returns:
ObjectsDataFile: objects data file or None if not available.
"""
filename_as_glob, _ = self._FormatFilenameAsGlob("objects.data")
filename_as_glob = self._FormatFilenameAsGlob("objects.data")
objects_data_file_glob = self._file_system_helper.JoinPath(
[path, filename_as_glob]
)
Expand Down Expand Up @@ -3953,7 +3953,7 @@ def _OpenRepositoryFile(self, path):
Returns:
RepositoryFile: repository file or None if not available.
"""
filename_as_glob, _ = self._FormatFilenameAsGlob("cim.rep")
filename_as_glob = self._FormatFilenameAsGlob("cim.rep")
repository_file_glob = self._file_system_helper.JoinPath(
[path, filename_as_glob]
)
Expand Down
17 changes: 16 additions & 1 deletion tests/wmi_repository.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -139,7 +139,22 @@ def testReadFileObject(self):
test_file.Open(test_file_path)


# TODO: add tests for CIMRepository
class CIMRepositoryTest(test_lib.BaseTestCase):
"""CIM repository tests."""

def testOpenAndClose(self):
"""Tests the Open and Close functions."""
test_directory_path = self._GetTestFilePath(["cim"])
self._SkipIfPathNotExists(test_directory_path)

test_repository = wmi_repository.CIMRepository()

test_repository.Open(test_directory_path)

try:
self.assertIsNotNone(test_repository.format_version)
finally:
test_repository.Close()


if __name__ == "__main__":
Expand Down