cmake: initialize SDLIMAGE_APNG_ENABLED unconditionally - #764
Merged
madebr merged 1 commit intoSep 11, 2026
Merged
Conversation
When configured with -DSDLIMAGE_PNG=OFF -Wdev, an AUTHOR_WARNING is triggered because SDLIMAGE_APNG_ENABLED was only set inside if(SDLIMAGE_PNG). Since APNG is unconditionally added to SDLIMAGE_BACKENDS, its enabled variable must always be defined for the backend reporting loop.
madebr
approved these changes
Sep 11, 2026
Contributor
|
Merged, thanks for the pull request! Pushed to 3.4.x as a324e90 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When configuring with
-DSDLIMAGE_PNG=OFF -Wdev, CMake triggers anAUTHOR_WARNING:APNGis unconditionally appended toSDLIMAGE_BACKENDS, butset(SDLIMAGE_APNG_ENABLED FALSE)was nested insideif(SDLIMAGE_PNG). When PNG is disabled, the reporting loop encounters an undefined variable.Moving
set(SDLIMAGE_APNG_ENABLED FALSE)outside the conditional ensures the variable is always defined.