Repository navigation
refactor(Channel): fetch channel based on channel identifier - #8849
Draft
FineFindus wants to merge 13 commits into
Draft
FineFindus wants to merge 13 commits into
FineFindus wants to merge 13 commits into
Conversation
Remove the special handling of the video tabs, instead relying only on the extracted channel tabs.
Moves the channel tab loading to a viewModel, following modern Android development best practices, keeping the data independent of the Fragment lifecycle.
This avoids reloading the channel tab when switching between tabs.
Implements support for displaying and using sort filter chips, that sort the channel tabs content according to the selected value.
Instead of using separate functions to retrieve the channel using an id or a name, use a single function that handles both, depending on the argument.
Some channel have an additional handle-based vanity URL in the form of `https://youtube.com/@handle` (which may not correspond to their ID or username). Closes libre-tube#8842
FineFindus
changed the title
Bnyro
approved these changes
Oct 15, 2026
Bnyro
left a comment
Bnyro
left a comment
Member
There was a problem hiding this comment.
Nice cleanup, I agree that this is much nicer than the different methods we had before.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactors the MediaServiceRepository to use a single function to retrieve the channel, irrespective of how the channel is identified (e.g. Id, Name or Handle).
In the longterm, I hope we can use this for all channel-based navigation, however it is difficult to refactor, as some fragments explicitly require the set data (e.g. the id for groups).
Closes #8842.
Requires #8791