Avoid initializing output arguments in translated tests#263
Merged
avalentino merged 1 commit intoJun 3, 2026
Conversation
Among other things, `erfa_generator` translates the ERFA tests in `t_erfa_c.c` into a `pytest` test suite for `pyerfa` ufuncs. The C tests have to initialize output arguments (or at least allocate them), but in the Python tests that step can be skipped without losing any test coverage.
eerovaher
commented
Jun 3, 2026
Comment on lines
-416
to
+419
| # If not, or one of iymdf or ihmsf, ignore (latter are outputs only). | ||
| if not rest or rest[:2] == "4]": | ||
| if ( | ||
| not rest | ||
| or name in self.func.doc.output # no need to initialize outputs | ||
| or name == "iydmf" # eraJdcalf test has a typo |
Contributor
Author
There was a problem hiding this comment.
The typo in the eraJdcalf test also means that iymdf the old comment refers to cannot be found by grepping.
avalentino
approved these changes
Jun 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Among other things,
erfa_generatortranslates the ERFA tests int_erfa_c.cinto apytesttest suite forpyerfaufuncs. The C tests have to initialize output arguments (or at least allocate them), but in the Python tests that step can be skipped without losing any test coverage. This PR shortens the generatederfa/tests/test_ufunc.pyfrom 3764 lines to 3617.