feat: open tabs from origin panel group - #807
Merged
Merged
Conversation
- Keep files and previews in the panel and split group they were opened from instead of jumping to the focused group. - Scope preview replacement to the origin group and reveal already open files in place. - Covers explorer, search, source control, pull requests, quick open, terminal composer, and editor/diff links.
Contributor
There was a problem hiding this comment.
✅ No new issues found.
Reviewed changes Origin sourceKey pins file, preview, and diff opens to the originating panel group instead of the focused one.
- Origin group resolution.
_groupForOpeningmaps a tool or tab key onto the main or right layout, and_openReplaceableTabsnapshots that group before the open queue so a later focus change cannot steal the tab. - Scoped preview replacement.
_previewTabIdInGrouponly replaces a preview in the resolved group, preferring that group's active preview. - Call-site threading. Explorer, search, source control, pull requests, single-tab surfaces, Quick Open, terminal composer, editor-to-diff, and diff-to-editor pass the origin key.
- Tests. New origin-panel cases cover both trees, in-flight opens, split-group placement, and keeping an already-open file where it already lives.
Grok | 𝕏
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

What changed
sourceKeyto file, editor, markdown, merman preview, git diff, git commit diff, and pull request diff open paths and resolves the opening group via_groupForOpening.readme.mdfile explorer behavior and addsworkbench_controller_origin_panel_test_cases.dartcoverage, with test fakes updated for the new signatures.Why