Skip to content

feat: offer remove workspace on mobile after a merged pull request - #800

Merged
leynier merged 2 commits into
mainfrom
feat/mobile-pr-remove-workspace
Sep 17, 2026
Merged

leynier merged 2 commits into
mainfrom
feat/mobile-pr-remove-workspace

Conversation

@leynier

@leynier leynier commented Sep 17, 2026

Copy link
Copy Markdown
Owner

Summary

On a merged linked review, the mobile Pull Request action bar now offers Remove Workspace as the primary action, matching desktop #784.

Tapping it runs the existing workspace removal confirmation (showDeleteWorkspaceDialog) and the same cascade / dependency / branch-delete path as the workspace actions sheet. Unlink stays in the overflow. Closed, open, and draft reviews are unchanged.

After a successful removal, the workspace tabs route is popped so the user is back on the workspace list.

No new runtime verbs or protocol version bump. Restack, Watch and Fix, and Ship are out of scope.

Screenshots

No device screenshots. Widget tests cover the merged, closed, no-mutations, confirm-and-delete, and return-to-list paths.

Testing

  • Added widget and unit tests for the new action
  • flutter test test/pull_request_actions_test.dart (puro Flutter 3.47.2)
  • flutter analyze on the touched mobile files
  • flutter test test/workspace_panels_test.dart test/workspace_panel_refresh_test.dart test/workspace_list_controller_test.dart

Full-repo format, coverage, and golden suites were not run.

Notes

Material risks

  • Removal is a destructive runtime action. A failed delete still reports through the existing snackbar path and does not pop the workspace.
  • If workspace mutations are unavailable, the button is omitted and unlink remains the only merged action.

When a linked review is merged, the mobile Pull Request action bar now
defaults to Remove Workspace and runs the same confirmation and delete
path as the workspace actions sheet. Unlink stays in the overflow.
Closed, open, and draft reviews are unchanged.
Keep the PR-panel confirmAndDeleteWorkspace launcher and use the #797
workspace removal dialog, including Keep Branch.

@pullfrog pullfrog Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ No new issues found.

Reviewed changes Mobile Pull Request panel after a merged review, matching desktop #784.

  • Merged primary action is Remove Workspace (destructive), with Unlink in the overflow; closed, open, and draft reviews stay as they were.
  • Mutation gating hides the new action when the paired runtime cannot mutate workspaces, defaulting to offer it until the list answers so Unlink does not flash as primary.
  • Shared removal launcher extracts confirmAndDeleteWorkspace from the workspace actions sheet so the panel uses the same confirm, cascade, dependency, and branch-delete path.
  • Post-delete navigation pops WorkspaceTabsScreen only after a successful remove; a failed delete snackbars and leaves the workspace open.
  • Tests cover the merged default, no-mutations, closed, confirm-before-delete, and return-to-list paths.

Pullfrog  | View workflow run | Using Grok𝕏

@pullfrog pullfrog Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ No new issues found.

Reviewed changes Merge of main into this branch since the prior review (ce98a51), which picks up the #797 removal dialog.

  • Shared launcher now calls showWorkspaceRemovalDialog and builds a WorkspaceRemovalDecision, including the named-branch canDeleteBranch gate from #797.
  • Widget tests assert Remove Workspace? and tap Remove so they match the merged dialog copy.

Pullfrog  | View workflow run | Using Grok𝕏

@leynier
leynier merged commit d1adb9b into main Sep 17, 2026
19 checks passed
@leynier
leynier deleted the feat/mobile-pr-remove-workspace branch September 17, 2026 06:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant