feat: offer remove workspace on mobile after a merged pull request - #800
Merged
Merged
Conversation
When a linked review is merged, the mobile Pull Request action bar now defaults to Remove Workspace and runs the same confirmation and delete path as the workspace actions sheet. Unlink stays in the overflow. Closed, open, and draft reviews are unchanged.
Keep the PR-panel confirmAndDeleteWorkspace launcher and use the #797 workspace removal dialog, including Keep Branch.
Contributor
There was a problem hiding this comment.
✅ No new issues found.
Reviewed changes Mobile Pull Request panel after a merged review, matching desktop #784.
- Merged primary action is Remove Workspace (destructive), with Unlink in the overflow; closed, open, and draft reviews stay as they were.
- Mutation gating hides the new action when the paired runtime cannot mutate workspaces, defaulting to offer it until the list answers so Unlink does not flash as primary.
- Shared removal launcher extracts
confirmAndDeleteWorkspacefrom the workspace actions sheet so the panel uses the same confirm, cascade, dependency, and branch-delete path. - Post-delete navigation pops
WorkspaceTabsScreenonly after a successful remove; a failed delete snackbars and leaves the workspace open. - Tests cover the merged default, no-mutations, closed, confirm-before-delete, and return-to-list paths.
Grok | 𝕏
Contributor
There was a problem hiding this comment.
✅ No new issues found.
Reviewed changes Merge of main into this branch since the prior review (ce98a51), which picks up the #797 removal dialog.
- Shared launcher now calls
showWorkspaceRemovalDialogand builds aWorkspaceRemovalDecision, including the named-branchcanDeleteBranchgate from #797. - Widget tests assert
Remove Workspace?and tapRemoveso they match the merged dialog copy.
Grok | 𝕏
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Summary
On a merged linked review, the mobile Pull Request action bar now offers Remove Workspace as the primary action, matching desktop #784.
Tapping it runs the existing workspace removal confirmation (
showDeleteWorkspaceDialog) and the same cascade / dependency / branch-delete path as the workspace actions sheet. Unlink stays in the overflow. Closed, open, and draft reviews are unchanged.After a successful removal, the workspace tabs route is popped so the user is back on the workspace list.
No new runtime verbs or protocol version bump. Restack, Watch and Fix, and Ship are out of scope.
Screenshots
No device screenshots. Widget tests cover the merged, closed, no-mutations, confirm-and-delete, and return-to-list paths.
Testing
flutter test test/pull_request_actions_test.dart(puro Flutter 3.47.2)flutter analyzeon the touched mobile filesflutter test test/workspace_panels_test.dart test/workspace_panel_refresh_test.dart test/workspace_list_controller_test.dartFull-repo format, coverage, and golden suites were not run.
Notes
confirmAndDeleteWorkspace.docs/architecture.mdalready describe Remove Workspace on the Pull Request panel after merge; no doc change.Material risks