Skip to content

ci: validate desktop stacks at an exact revision - #575

Draft
leynier wants to merge 16 commits into
mainfrom
workflows/01-ci
Draft

leynier wants to merge 16 commits into
mainfrom
workflows/01-ci

Conversation

@leynier

@leynier leynier commented Aug 30, 2026

Copy link
Copy Markdown
Owner

Adds exact-trigger-SHA desktop validation with optional goldens and Linux E2E, a fail-closed completion gate, and contributor instructions. Existing reusable callers remain build-only. The smoke fixture suppresses quota discovery that could start installed CLIs or login flows.

Head: 839d5e799fab406322a54dc43965237a4c4a8aa8. Base snapshot: 509a58c7afd564eb73426f397723eba2a582796a. Incorporates Dart 3.13 modernization and workspace sections, retaining native process, smoke and clipboard checks. Clipboard coverage opts in only on disposable runner desktops.

Local validation passed reproducible desktop/mobile generation, formatting, full Flutter analysis, max-lines, actionlint, whitespace, full Rust validation (1939 passed, four intentional ignores), 44 focused/golden tests and nine native Linux E2E cases in isolated Xvfb sessions. Review 15 with Codex gpt-5.6-sol high passed without findings; worktree unchanged and session archived. PR Checks and CodeQL passed, including previous-host compatibility. Full exact-head desktop validation passed on the first attempt: goldens, Linux E2E, Linux/macOS/Windows builds and native checks, plus the final aggregate. Remote base and head reverified unchanged. Prior-head approvals and checks do not satisfy a refreshed pair.

Security: read-only token; no persisted checkout credentials, signing, publishing, or merge-policy changes. No visual change. Layer 1 of native stack #582; remains draft until the complete stack passes validation.

All nine current-head native typography captures are byte-identical to inspected same-platform references; artifact ZIP digests verified. Evidence limitation: hosted Linux captures have preexisting missing Japanese glyphs and do not establish CJK font coverage. No rendering code changed in this layer.

Comment thread .github/workflows/desktop-build.yml Fixed
Comment thread .github/workflows/desktop-build.yml Fixed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants