Conversation
…te key When an incorrect passphrase is provided, lcobucci throws a generic RuntimeException with OpenSSL internals. Wrap the signing operation in a try/catch to rethrow with a clear, actionable message. The loadKey() call is intentionally left outside the try/catch so key-loading errors propagate unchanged. Fixes lexik#1262
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When an incorrect passphrase is provided for the private key, the error message is unclear:
The root cause is not obvious — lcobucci throws a
RuntimeExceptionwith raw OpenSSL internals likebad decryptwhich don't help the developer identify the passphrase as the issue.Fixes #1262
Solution
Wrap the signing operation in
LcobucciJWSProvider::getSignedToken()in a try/catch. When lcobucci throws duringInMemory::plainText()orgetToken(), rethrow as\InvalidArgumentExceptionwith a clear message pointing to the passphrase.The
loadKey()call is intentionally left outside the try/catch so key-loading errors (wrong file, unsupported format) propagate with their original messages unchanged.Changes
Services/JWSProvider/LcobucciJWSProvider.php— wrap signing in try/catchTests/Services/JWSProvider/LcobucciJWSProviderTest.php— add test for invalid passphrase scenario