Conversation
We've been observing spikes in memory usage in the WFE. To track them down, we'd like to automatically trigger writing profiles to disk when memory usage is high. This is controlled by two environment variables: - If $GOMEMLIMIT is unset, the profile dumping does not happen. This value is also used by the Go runtime to set a soft limit, and we intend to set it to something below where the OS will kill the process. https://pkg.go.dev/runtime#hdr-Environment_Variables - Files are written with os.CreateTemp(), so their location can be controlled with $TMPDIR.
Contributor
|
Haven't read in detail yet, but for the question in the PR description: under the current logging regime, this could use blog.Get() to acquire a default logger for errors, instead of using fmt.Print directly. Under the upcoming logging regime, if this code were in cmd/ instead of cmd/boulder/, it could use the same backupLogger used by cmd.AuditPanic. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We've been observing spikes in memory usage in the WFE. To track them down, we'd like to automatically trigger writing profiles to disk when memory usage is high.
This is controlled by two environment variables:
Draft to seek feedback about logging. The current version gets run from
cmd/boulder/main.go, before a logger is built. It usesfmt.Println()for errors. To use a real logger, we'd need to makememoryMonitor()exported and call it from each of the Boulder components after their config is parsed and the logger is built. Thoughts?