Add 72x40 display#5546
Conversation
|
I assume you did test it yourself on your board after these last changes? |
| F("64x48"), | ||
| F("72x40") }; | ||
| FormSelectorOptions selector(NR_ELEMENTS(options3), options3, values); |
There was a problem hiding this comment.
Because of the way this is constructed, this will crash when configuring the display configuration in P023, as that plugin won't provide the 4th option value.
I think the number of items to display in the selector will have to be added as a new argument to the function, can default to 3, for 'other plugins using this function', and from P036 a value of 4 should be provided (or the length of the values array, like NR_ELEMENTS(optionValues)).
There was a problem hiding this comment.
Alternatively, you can change the signature for the function, having const int values[] (also in the .h file), and take the NR_ELEMENTS(values) instead of NR_ELEMENTS(options3), that would be an easier change 😉
3 participants
I added the 72x40 display for ESP32-C3 dev board like this:
https://emalliab.wordpress.com/2025/02/12/esp32-c3-0-42-oled/