feat(controls): Switch from StackPanel to VirtualizingStackPanel in ComboBox to prevent long load times#1703
Open
steven-norris wants to merge 4 commits intolepoco:mainfrom
Open
feat(controls): Switch from StackPanel to VirtualizingStackPanel in ComboBox to prevent long load times#1703steven-norris wants to merge 4 commits intolepoco:mainfrom
StackPanel to VirtualizingStackPanel in ComboBox to prevent long load times#1703steven-norris wants to merge 4 commits intolepoco:mainfrom
Conversation
StackPanel to VirtualizingStackPanel to prevent long load times and UI lockups when the ComboBox binding contains sufficiently large list of items.
github-actions
Bot
added
controls
Author
|
Added issue #1704 with more information on the problem. |
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the Wpf.Ui library ComboBox control template to improve dropdown performance when bound to large item sources by moving toward UI virtualization.
Changes:
- Replaced the ComboBox
ItemsPanelTemplatefromStackPaneltoVirtualizingStackPanelin the default ComboBox style.
pomianowski
changed the title
StackPanel to VirtualizingStackPanel in ComboBox to prevent long load times
I failed when I updated this code on my phone.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
StackPanel to VirtualizingStackPanel to prevent long load times and UI lockups when the ComboBox binding contains sufficiently large list of items.
Pull request type
Please check the type of change your PR introduces:
What is the current behavior?
In the last update this was changed to include a in the item template of the ComboBox, this should be a to avoid long load times and UI lockups, only drawing what is visible to the user at open/scroll time.
Issue Number: N/A
What is the new behavior?
UI only loads/draws what is requested by the user. This is a long-known issue w/ComboBox.