Skip to content

SRV record lookup #50

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
feuerrot wants to merge 1 commit into
base: master
Choose a base branch
from
Open

SRV record lookup #50

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 18 additions & 4 deletions gumbleutil/main.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,10 +31,24 @@ func Main(listeners ...gumble.EventListener) {
flag.Parse()
}

host, port, err := net.SplitHostPort(*server)
if err != nil {
host = *server
port = strconv.Itoa(gumble.DefaultPort)
var host string
var port string

// try to lookup SRV records first
_, records, err := net.LookupSRV("mumble", "tcp", *server)
if err == nil {
// just use the first one, which probably isn't a good idea
for _, srv := range records {
host = srv.Target
port = strconv.Itoa(int(srv.Port))
break
}
} else {
host, port, err = net.SplitHostPort(*server)
if err != nil {
host = *server
port = strconv.Itoa(gumble.DefaultPort)
}
}

keepAlive := make(chan bool)
Expand Down