Fix: Ensure consistent character encoding in HTTP response handling#210
Merged
Merged
Conversation
Updated EntityUtils.toString calls to specify StandardCharsets.UTF_8 for consistent character encoding across multiple classes, including CipherManager, Web, and NonMusicClient. Added .cursor to .gitignore to exclude cursor files from version control.
Member
|
Have you personally run into any issues from the charset not being explicitly defined, or is this just AI junk? |
Contributor
|
AI slop ref: #197 (comment) |
Contributor
Author
|
I have personally run into this issue. I incorporated the changes into my application and it fixed my issue when I was playing music from youtube with cyrillic characters I was previously fixing this on the application level (in MusicBot) but this felt wrong. Fixing this upstream so applications don't have to deal with this is preferable. I can try to provide before and after pictures if that would help convince you. |
Contributor
Author
|
@sqikerz I am not sure why you are being so hostile |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR ensures that calls to
EntityUtils.toStringspecify UTF_8 character encoding. This resolves issues with mojibake when system default character encoding is NOT UTF_8.Commit Message
Updated EntityUtils.toString calls to specify StandardCharsets.UTF_8 for consistent character encoding across multiple classes, including CipherManager, Web, and NonMusicClient.
Added .cursor to .gitignore to exclude cursor files from version control.