-
Notifications
You must be signed in to change notification settings - Fork 13
fix: improve robustness with nil-safe context handling and proper error propagation #664
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from 9 commits
45ab0dc
79470d8
aef5e33
24e818c
16d3870
a824232
ef494c3
9a1739d
096dac8
61bdac2
2dd4983
2b7a3b1
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -12,19 +12,4 @@ jobs: | |
| - uses: actions/checkout@v4 | ||
| - name: Check OpenAPI updates | ||
| run: make openapi-spec-check-updates | ||
| on-failure: | ||
| runs-on: ubuntu-latest | ||
| if: ${{ always() && (needs.check-open-api-spec-updates.result == 'failure' || needs.check-open-api-spec-updates.result == 'timed_out') }} | ||
| needs: | ||
| - check-open-api-spec-updates | ||
| steps: | ||
| - uses: actions/checkout@v4 | ||
| - name: Send Slack notification | ||
| uses: rtCamp/action-slack-notify@v2 | ||
| env: | ||
| SLACK_CHANNEL: proj-cli | ||
| SLACK_COLOR: ${{ job.status }} | ||
| SLACK_ICON_EMOJI: ':launchdarkly:' | ||
| SLACK_TITLE: ':warning: The OpenAPI spec has changed and resources need to be updated.' | ||
| SLACK_USERNAME: github | ||
| SLACK_WEBHOOK: ${{ secrets.SLACK_WEBHOOK_URL }} | ||
| continue-on-error: true | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Hey @Rayhan1967 , mind taking a look at this pr again, I see some changes that are a bit concerning like the Readme and this change - would be helpful to understand the why behind these changes, Thank you! |
||
This file was deleted.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Slack failure notification silently removed and replaced with no-op
Medium Severity
The
on-failurejob that sent Slack notifications when the OpenAPI spec check failed has been completely removed and replaced withcontinue-on-error: trueat the job level. This silently swallows failures instead of alerting the team, meaning the team will no longer be notified when the OpenAPI spec changes and resources need updating.