Skip to content

feat: support waitForNetworkResults in FDv2 data manager#1280

Draft
kinyoklion wants to merge 1 commit intomainfrom
rlamb/sdk-2177/fdv2-rn-wait-for-network-results
Draft

feat: support waitForNetworkResults in FDv2 data manager#1280
kinyoklion wants to merge 1 commit intomainfrom
rlamb/sdk-2177/fdv2-rn-wait-for-network-results

Conversation

@kinyoklion
Copy link
Copy Markdown
Member

@kinyoklion kinyoklion commented Apr 15, 2026

The FDv2 data manager now respects the waitForNetworkResults identify option. When false (the default for mobile), identify resolves as soon as cached data is delivered rather than waiting for network.

Requirements

  • I have added test coverage for new or changed functionality
  • I have followed the repository's pull request submission guidelines
  • I have validated my changes against all supported platform versions

Related issues

Provide links to any issues in this repository or elsewhere relating to this pull request.

Describe the solution you've provided

Provide a clear and concise description of what you expect to happen.

Describe alternatives you've considered

Provide a clear and concise description of any alternative solutions or features you've considered.

Additional context

Add any other context about the pull request here.


Note

Medium Risk
Changes when the identify promise resolves (cached-first vs network-fresh), which can alter initialization timing and app control flow across platforms.

Overview
FDv2DataManagerBase now respects LDIdentifyOptions.waitForNetworkResults by tracking a minimumDataAvailability threshold for identify completion.

When configured to not wait for network results, identify can resolve as soon as any initial data (e.g. cache) is delivered via dataCallback, while the data source continues initializing and applying subsequent updates as they arrive.

Reviewed by Cursor Bugbot for commit a2244e6. Bugbot is set up for automated code reviews on this repo. Configure here.

The FDv2 data manager now respects the waitForNetworkResults identify
option. When false (the default for mobile), identify resolves as
soon as cached data is delivered rather than waiting for network.
@github-actions
Copy link
Copy Markdown
Contributor

@launchdarkly/js-sdk-common size report
This is the brotli compressed size of the ESM build.
Compressed size: 25623 bytes
Compressed size limit: 29000
Uncompressed size: 125843 bytes

@github-actions
Copy link
Copy Markdown
Contributor

@launchdarkly/browser size report
This is the brotli compressed size of the ESM build.
Compressed size: 179328 bytes
Compressed size limit: 200000
Uncompressed size: 830158 bytes

@github-actions
Copy link
Copy Markdown
Contributor

@launchdarkly/js-client-sdk size report
This is the brotli compressed size of the ESM build.
Compressed size: 31722 bytes
Compressed size limit: 34000
Uncompressed size: 112975 bytes

@github-actions
Copy link
Copy Markdown
Contributor

@launchdarkly/js-client-sdk-common size report
This is the brotli compressed size of the ESM build.
Compressed size: 37417 bytes
Compressed size limit: 38000
Uncompressed size: 205446 bytes

@kinyoklion
Copy link
Copy Markdown
Member Author

bugbot review

Copy link
Copy Markdown

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Bugbot reviewed your changes and found no new issues!

Comment @cursor review or bugbot run to trigger another review on this PR

Reviewed by Cursor Bugbot for commit a2244e6. Configure here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant