chore: Add FDv2 example project for react-native.#1277
chore: Add FDv2 example project for react-native.#1277kinyoklion wants to merge 8 commits intomainfrom
Conversation
The public API shows setConnectionMode(mode: ConnectionMode) and getConnectionMode(): ConnectionMode. The FDv2-specific overloads accepting FDv2ConnectionMode and undefined are stripped from declarations via @internal + stripInternal.
kinyoklion
changed the title
|
@launchdarkly/js-sdk-common size report |
|
@launchdarkly/browser size report |
|
@launchdarkly/js-client-sdk size report |
|
@launchdarkly/js-client-sdk-common size report |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 2 potential issues.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 3f9c780. Configure here.
| version: '0.0.1', | ||
| }, | ||
| baseUri: 'http://192.168.7.152:3002/proxy-poll', | ||
| streamUri: 'http://192.168.7.152:3001/proxy', |
There was a problem hiding this comment.
Hardcoded local IP addresses in example app config
Medium Severity
The baseUri and streamUri are hardcoded to a developer-specific local network address (192.168.7.152), which won't work for anyone else cloning the repo. The existing example/App.tsx doesn't set these, relying on SDK defaults. These look like leftover development/debugging proxy configuration that was accidentally committed.
Reviewed by Cursor Bugbot for commit 3f9c780. Configure here.
| - "settings.json": contains the server configuration that is used to serve the application manifest. | ||
| > Should I commit the ".expo" folder? | ||
| No, you should not share the ".expo" folder. It does not contain any information that is relevant for other developers working on the project, it is specific to your machine. | ||
| Upon project creation, the ".expo" folder is already added to your ".gitignore" file. |
There was a problem hiding this comment.
Committed .expo directory that should be gitignored
Low Severity
The .expo directory is committed, but its own README.md explicitly states it should not be shared and is machine-specific. The existing example has a .gitignore that excludes .expo/, but example-fdv2 is missing a .gitignore entirely, causing these files to be tracked.
Additional Locations (1)
Reviewed by Cursor Bugbot for commit 3f9c780. Configure here.
1 participant
Note
Medium Risk
Mostly adds a new example app, but it also modifies the root Yarn workspaces list and
packages/sdk/react-native/tsconfig.jsonexcludes, which can affect installs/builds and CI behavior.Overview
Adds a new
packages/sdk/react-native/example-fdv2Expo app workspace that initializes the RN SDK with the experimentaldataSystem(FDv2) option and includes a simple UI toidentify, evaluate a boolean flag, and toggle FDv2 connection modes via the internalsetConnectionMode()API.Updates the monorepo to include this workspace (root
package.json) and prevents it from being picked up by the main React Native package TypeScript build (packages/sdk/react-native/tsconfig.jsonexclude).Reviewed by Cursor Bugbot for commit 3f9c780. Bugbot is set up for automated code reviews on this repo. Configure here.