Repository navigation
feat: add hex input to latch-dump - #25
Conversation
94322bc to
ced64de
Compare
ced64de to
a9e0518
Compare
TheusHen
left a comment
There was a problem hiding this comment.
Thanks, @ahmadalguydi — this is a useful and well-scoped contribution.
I reviewed the parser, CLI behavior, bounds, diagnostics, tests, documentation, and the unchanged binary path. Because #10 landed after this work started, I rebased the branch onto the current prod and resolved the README/CMake divergence without reverting the public-launch changes.
During the rebase I made a few small maintainer adjustments: deterministic ASCII-whitespace handling, correct usage for --hex without a file, one shared envelope validation/output path for binary and hex input, and additional coverage for the missing-argument and binary-output cases.
Validation is complete: 28/28 tests passed locally, including latch-dump-hex-tests, and the full GitHub matrix is green, including the required gate, multiplatform CI, CodeQL, quality, coverage, cross-toolchains, reproducibility, dependency checks, Rust, and libFuzzer.
The implementation is bounded, keeps the existing binary interface compatible, and satisfies #11. Approved.
Summary
latch-dump --hexmode that accepts ASCII whitespace between byte pairsThe default binary-file path remains unchanged. Hex decoding writes directly into a buffer bounded by
LS_MAX_EVENT_SIZE, so oversized input is rejected before envelope validation or any unbounded allocation.Validation
python -m py_compile tests/test_latch_dump.pygit diff --checkFixes #11