Text rotation#424
Closed
15artis wants to merge 12 commits into
Closed
Conversation
Contributor
Author
|
Need to add add_xform() to render_glyph |
|
Is there anything else needs implemented? I can lend a hand but this looks pretty feature complete to me |
Contributor
Author
|
text supports rotation at any Angle, but borders do not |
panekj
requested changes
Apr 21, 2024
Comment on lines
+1024
to
+1031
| #[derive(Debug, Clone, Copy, PartialEq, Eq)] | ||
| pub enum Rotation { | ||
| Rotation0, | ||
| Rotation90, | ||
| Rotation180, | ||
| Rotation270, | ||
| } | ||
|
|
Collaborator
There was a problem hiding this comment.
This should have better naming like:
Suggested change
| #[derive(Debug, Clone, Copy, PartialEq, Eq)] | |
| pub enum Rotation { | |
| Rotation0, | |
| Rotation90, | |
| Rotation180, | |
| Rotation270, | |
| } | |
| #[derive(Debug, Clone, Copy, PartialEq, Eq)] | |
| pub enum Rotation { | |
| NoRotation, | |
| RotateRight, | |
| RotateUpsideDown, | |
| RotateLeft, | |
| } |
Collaborator
There was a problem hiding this comment.
although I don't feel like rotate is anyhow good
Collaborator
There was a problem hiding this comment.
Preferably it should somehow comply with how CSS defines this attributes
Contributor
Author
There was a problem hiding this comment.
ok, thanks for your advice. I will revise it right away
Comment on lines
+1739
to
+1751
| pub fn rotation_0(self) -> Self { | ||
| self.rotation(Rotation::Rotation0) | ||
| } | ||
| pub fn rotation_90(self) -> Self { | ||
| self.rotation(Rotation::Rotation90) | ||
| } | ||
| pub fn rotation_180(self) -> Self { | ||
| self.rotation(Rotation::Rotation180) | ||
| } | ||
| pub fn rotation_270(self) -> Self { | ||
| self.rotation(Rotation::Rotation270) | ||
| } | ||
|
|
Contributor
|
Does this require the vger RP? |
Contributor
Author
|
yes |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.