fix(embed): isolate browser chat sessions#2335
Merged
Merged
Conversation
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
e04582b to
a980aff
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Isolate embedded web-chat conversations by browser-tab session so visitors using the same pipeline cannot see or receive each other's messages.
sessionStorageacross refreshes.Closes #2334
Screenshots
Not applicable; this is a WebSocket/session-isolation fix. Regression behavior is covered by unit and API integration tests.
Verification
106 passed— platform unit tests (excluding the unrelated existing DingTalk collection conflict)17 passed—tests/integration/api/test_embed.py30 passed— focused WebSocket isolation, attachment, and embed API suitenode --check src/langbot/templates/embed/widget.jspassedgit diff --checkpassedChecklist