fix: skip valkey-glide on Windows#2333
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
valkey-glideas a non-Windows dependency and refreshuv.lockglideand document Windows supportRoot cause
The Valkey Search integration added
valkey-glideas an unconditional direct dependency. The published package provides macOS and manylinux wheels but no Windows wheel, so Windows installs fall back to a source build and fail.Impact
LangBot can be installed normally on Windows without
valkey-glide. The Valkey Search backend remains automatically available on supported platforms and reports a clear error if selected where the client is unavailable.Validation
uv lock --checkvalkey-glidevalkey-glide45 passed, 10 skippedfor the related vector testsruff checkon the changed Python filesgit diff --cached --check