Skip to content

fix: skip valkey-glide on Windows#2333

Merged
RockChinQ merged 2 commits into
masterfrom
agent/fix-valkey-windows-dependency
Jul 12, 2026
Merged

fix: skip valkey-glide on Windows#2333
RockChinQ merged 2 commits into
masterfrom
agent/fix-valkey-windows-dependency

Conversation

@RockChinQ

Copy link
Copy Markdown
Member

Summary

  • mark valkey-glide as a non-Windows dependency and refresh uv.lock
  • keep the Valkey Search backend optional when the client is unavailable
  • make Valkey tests skip safely without glide and document Windows support

Root cause

The Valkey Search integration added valkey-glide as an unconditional direct dependency. The published package provides macOS and manylinux wheels but no Windows wheel, so Windows installs fall back to a source build and fail.

Impact

LangBot can be installed normally on Windows without valkey-glide. The Valkey Search backend remains automatically available on supported platforms and reports a clear error if selected where the client is unavailable.

Validation

  • uv lock --check
  • Windows dependency resolution excludes valkey-glide
  • Linux dependency resolution includes valkey-glide
  • 45 passed, 10 skipped for the related vector tests
  • ruff check on the changed Python files
  • git diff --cached --check

@codecov

codecov Bot commented Jul 12, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@RockChinQ RockChinQ marked this pull request as ready for review July 12, 2026 16:21
@dosubot dosubot Bot added size:S This PR changes 10-29 lines, ignoring generated files. dependencies 依赖库相关 / deps related labels Jul 12, 2026
@RockChinQ RockChinQ merged commit 3ddebd2 into master Jul 12, 2026
21 checks passed
@github-actions github-actions Bot locked and limited conversation to collaborators Jul 12, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

dependencies 依赖库相关 / deps related size:S This PR changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants