Repository navigation
fix: MySQL 8.2+ and mysql:8 failing to start - #81
Merged
Merged
Conversation
✅ Deploy Preview for lando-joomla ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

MySQL 8.2 removed
expire_logs_days, but the recipe's MySQL 8 config still sets it, somysql:8.2,8.3and8.4abort on startup withunknown variable 'expire_logs_days=10'. The baremysql:8alias (MySQL 8.4.5) was also loading the 5.7 config file and failing onquery_cache_limit.expire_logs_days = 10withbinlog_expire_logs_seconds = 864000: same 10 days, supported since MySQL 8.0.1mysql:8to the MySQL 8 configexamples/joomla-mysql84onmysql:8to CIVerified locally on Lando 3.26.9:
lando startwithdatabase: mysql:8boots MySQL 8.4.5 with the MySQL 8 config andbinlog_expire_logs_seconds=864000.Same bug as lando/laravel#114.
Note
Medium Risk
Changes default MySQL config files for all 8.x database options; mis-version detection could still pick the wrong cnf, but the fix is narrowly scoped to known startup breakages.
Overview
Fixes Joomla recipe MySQL startup failures on MySQL 8.2+ and the
mysql:8alias.MySQL 8 config:
mysql8.cnfnow setsbinlog_expire_logs_seconds = 864000instead of the removedexpire_logs_days, so 8.2/8.3/8.4 no longer abort on unknown variable errors.Config selection:
getConfigDefaultstreats any 8.x database version (including baremysql:8) as MySQL 8 and appliesmysql8.cnf, instead of only matching8.and falling back to the 5.7mysql.cnf(which breaks on 8.4 with settings likequery_cache_limit).CI: Adds
examples/joomla-mysql84Leia coverage fordatabase=mysql:8and pinsrun-leia-actionto1.0.0-beta.4. Changelog entries document both fixes.Reviewed by Cursor Bugbot for commit d1cd2a4. Bugbot is set up for automated code reviews on this repo. Configure here.