spec-sync(v2): send jobs-list page_size as pageSize on the wire - #159
Open
yzld2002 wants to merge 2 commits into
Open
spec-sync(v2): send jobs-list page_size as pageSize on the wire#159yzld2002 wants to merge 2 commits into
yzld2002 wants to merge 2 commits into
Conversation
Contributor
There was a problem hiding this comment.
🔵 Needs a closer look
Specification and generated-contract changes require final human review.
Pull request overview
Updates the mirrored V2 OpenAPI specification and regenerated reference models to track upstream drift.
Changes:
- Renames pagination parameters to
pageSize. - Adds
cancelledto applicable job-status enums.
File summaries
| File | Description |
|---|---|
specs/v2-aide.json |
Updates the V2 specification snapshot. |
specs/_generated/v2_models.py |
Regenerates reference models from the updated snapshot. |
Review details
- Files reviewed: 2/2 changed files
- Comments generated: 0
- Review effort level: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Automated V2 spec-sync PR (
client.v2).Gates (surface-lock, V2 contract tests, lint/test/typecheck) must pass. When present, the AI commit is a draft a human finishes (the V2 ergonomic layer — unified Job, dual-host, schema coercion — is not in the spec). Human review required before merge.
What changed
AI-generated from the PR diff — verify against the actual changes.
This PR updates the V2 jobs-list wire format to use
pageSizeas the query parameter name and addscancelledas a recognized terminal status for extract jobs.Changes:
client.v2.parse_jobs.listandclient.v2.extract_jobs.listnow send thepage_size=keyword on the wire aspageSize(response envelope still returnspage_sizeunchanged).page/page_size/statuson jobs-list calls are now omitted from the query entirely instead of sent empty, deferring to gateway defaults (page=0,pageSize=10).extract_jobs.waitnow treatscancelledas a documented, terminal extract-job status and returns the cancelled job instead of polling to the timeout.build_jobs_list_queryshared helper centralizing thepage_size→pageSizewire mapping used by parse, extract, and build-schema jobs-list requests.