Skip to content

spec-sync(v2): send jobs-list page_size as pageSize on the wire - #159

Open
yzld2002 wants to merge 2 commits into
mainfrom
spec-sync/v2
Open

spec-sync(v2): send jobs-list page_size as pageSize on the wire#159
yzld2002 wants to merge 2 commits into
mainfrom
spec-sync/v2

Conversation

@yzld2002

@yzld2002 yzld2002 commented Sep 8, 2026

Copy link
Copy Markdown
Member

Automated V2 spec-sync PR (client.v2).

  • Commit 1 (mechanical): normalized V2 spec snapshot + regenerated reference models.
  • Commit 2 (AI, only if the spec diff needs SDK changes): client.v2 resources/methods/tests/docs wired from the diff, added after this PR opened. Workflow-only drift is excluded and an AI no-op is skipped, so some drifts produce a mechanical-only PR with no second commit.

Gates (surface-lock, V2 contract tests, lint/test/typecheck) must pass. When present, the AI commit is a draft a human finishes (the V2 ergonomic layer — unified Job, dual-host, schema coercion — is not in the spec). Human review required before merge.

What changed

AI-generated from the PR diff — verify against the actual changes.

This PR updates the V2 jobs-list wire format to use pageSize as the query parameter name and adds cancelled as a recognized terminal status for extract jobs.

Changes:

  • client.v2.parse_jobs.list and client.v2.extract_jobs.list now send the page_size= keyword on the wire as pageSize (response envelope still returns page_size unchanged).
  • Unset page/page_size/status on jobs-list calls are now omitted from the query entirely instead of sent empty, deferring to gateway defaults (page=0, pageSize=10).
  • extract_jobs.wait now treats cancelled as a documented, terminal extract-job status and returns the cancelled job instead of polling to the timeout.
  • Added build_jobs_list_query shared helper centralizing the page_sizepageSize wire mapping used by parse, extract, and build-schema jobs-list requests.

Copilot AI balanced review requested due to automatic review settings September 8, 2026 19:02
@yzld2002
yzld2002 deployed to spec-sync-contract September 8, 2026 19:02 — with GitHub Actions Active

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔵 Needs a closer look

Specification and generated-contract changes require final human review.

Pull request overview

Updates the mirrored V2 OpenAPI specification and regenerated reference models to track upstream drift.

Changes:

  • Renames pagination parameters to pageSize.
  • Adds cancelled to applicable job-status enums.
File summaries
File Description
specs/v2-aide.json Updates the V2 specification snapshot.
specs/_generated/v2_models.py Regenerates reference models from the updated snapshot.
Review details
  • Files reviewed: 2/2 changed files
  • Comments generated: 0
  • Review effort level: Balanced

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Copilot AI review requested due to automatic review settings September 8, 2026 19:12
@yzld2002
yzld2002 deployed to spec-sync-contract September 8, 2026 19:12 — with GitHub Actions Active
@yzld2002 yzld2002 changed the title spec-sync: track V2 spec drift spec-sync(v2): send jobs-list page_size as pageSize on the wire Sep 8, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔵 Needs a closer look

The generated contract and client changes require final human review before merge.

Review details
  • Files reviewed: 13/13 changed files
  • Comments generated: 0 new
  • Review effort level: Balanced

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants