feat: display Iceberg field documentation - #274
Conversation
|
Warning Review limit reached
Next review available in: 64 minutes You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
WalkthroughTableColumnProfiler now propagates Iceberg field documentation through top-level and nested schema nodes. The component renders documentation below field names, wraps long text, and includes tests for schema selection and nested-field navigation. ChangesSchema documentation display
Estimated code review effort: 3 (Moderate) | ~20 minutes Sequence Diagram(s)sequenceDiagram
participant IcebergSchema
participant TableColumnProfiler
participant SchemaTable
IcebergSchema->>TableColumnProfiler: Provide field documentation
TableColumnProfiler->>TableColumnProfiler: Propagate documentation through schema nodes
TableColumnProfiler->>SchemaTable: Render documentation below field names
Suggested reviewers: Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
🧹 Nitpick comments (1)
src/components/TableColumnProfiler.test.ts (1)
97-104: 📐 Maintainability & Code Quality | 🔵 Trivial | ⚡ Quick winScope the assertions to field documentation nodes.
wrapper.text()does not verify that the documentation renders beneath the field name. Query.field-docso the test verifies the new display contract before and after expansion.Proposed test update
- expect(wrapper.text()).toContain('Current customer record'); - expect(wrapper.text()).not.toContain('Legacy field'); - expect(wrapper.text()).not.toContain('Primary contact address'); + const fieldDocs = () => wrapper.findAll('.field-doc').map((node) => node.text()); + expect(fieldDocs()).toEqual(['Current customer record']); await wrapper.get('button[data-icon="mdi-chevron-right"]').trigger('click'); await nextTick(); - expect(wrapper.text()).toContain('Primary contact address'); + expect(fieldDocs()).toEqual(['Current customer record', 'Primary contact address']);🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@src/components/TableColumnProfiler.test.ts` around lines 97 - 104, Update the assertions in the TableColumnProfiler test to query `.field-doc` elements instead of using `wrapper.text()`, both before and after triggering the expansion button. Verify the expected documentation is present or absent within those field documentation nodes while preserving the existing expansion flow.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Nitpick comments:
In `@src/components/TableColumnProfiler.test.ts`:
- Around line 97-104: Update the assertions in the TableColumnProfiler test to
query `.field-doc` elements instead of using `wrapper.text()`, both before and
after triggering the expansion button. Verify the expected documentation is
present or absent within those field documentation nodes while preserving the
existing expansion flow.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro Plus
Run ID: 9ac7c5a4-d794-4b01-84d9-69ceb6ef6058
📒 Files selected for processing (2)
src/components/TableColumnProfiler.test.tssrc/components/TableColumnProfiler.vue
Summary
Testing
npm testjust reviewableCloses #273
BEGIN_COMMIT_OVERRIDE
feat(ui): display Iceberg field documentation
END_COMMIT_OVERRIDE
Summary by CodeRabbit
New Features
Tests