Skip to content

fix: make external S3 endpoint check non-blocking during health check #6864

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
TheOne-Xin wants to merge 5 commits into
base: main
Choose a base branch
from
+8 −4
Open

fix: make external S3 endpoint check non-blocking during health check #6864

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
13dcba4
fix: fix left-aligned list marker styling in chat welcome guide
TheOne-Xin Mar 31, 2026
1e8bb15
Merge branch 'main' into feature/fix-bug
TheOne-Xin Apr 30, 2026
8a2b70c
fix: make external S3 endpoint check non-blocking during health check
TheOne-Xin Apr 30, 2026
6398f9d
Merge branch 'labring:main' into feature/fix-bug
TheOne-Xin Apr 30, 2026
c9d8765
Merge branch 'feature/fix-bug' of github.com:TheOne-Xin/FastGPT into …
TheOne-Xin Apr 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 8 additions & 4 deletions packages/service/common/s3/buckets/base.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,10 +86,14 @@ export class S3BaseBucket {
});

try {
await Promise.all([
this.client.getObjectMetadata({ key }),
this._externalClient?.checkObjectExists({ key })
]);
await this.client.getObjectMetadata({ key });
if (this._externalClient) {
this._externalClient.checkObjectExists({ key }).catch((err) => {
logger.warn('External S3 endpoint check failed, using internal only', {
error: err?.message || String(err)
});
});
}
} finally {
await this.client.deleteObject({ key }).catch((err) => {
if (isFileNotFoundError(err)) {
Expand Down
Loading