fix(oss): use list() instead of getBucketInfo() in ensureBucket to avoid bundling issue#6833
Open
octo-patch wants to merge 1 commit into
Open
fix(oss): use list() instead of getBucketInfo() in ensureBucket to avoid bundling issue#6833octo-patch wants to merge 1 commit into
octo-patch wants to merge 1 commit into
Conversation
…oid bundling issue
When using OSS storage with Next.js, getBucketInfo() triggers
"ReferenceError: name is not defined" at startup. This happens because
the ali-oss SDK references a variable named `name` internally in its
createRequest function, which conflicts with the global `name` property
in bundled JavaScript environments.
Replacing getBucketInfo() with list({ 'max-keys': 1 }) achieves the same
goal (verifying the bucket is accessible) while avoiding the problematic
code path. The list() method is already used successfully elsewhere in
the OSS adapter.
Fixes labring#6552
Co-Authored-By: Octopus <liyuan851277048@icloud.com>
|
octo-patch seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
1 similar comment
|
octo-patch seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
|
✅ Build Successful - Preview code-sandbox Image for this PR: |
|
✅ Build Successful - Preview fastgpt Image for this PR: |
|
✅ Build Successful - Preview mcp_server Image for this PR: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #6552
Problem
When OSS storage is configured, the application logs the following error on startup:
This happens because ali-oss's getBucketInfo() internally references a variable named
namein its createRequest() function. In bundled environments (Next.js webpack), this conflicts with JavaScript's implicit globalnameproperty — resulting in a ReferenceError every time the application starts with OSS configured.The error is non-fatal (caught and logged), but confusing: users see an alarming error even though their OSS bucket exists and uploads work fine.
Solution
Replace getBucketInfo() with list({ 'max-keys': 1 }) in the ensureBucket() method of the OSS adapter. The list() call:
Testing