Skip to content

fix: merge alembic heads c7d58e2a4f93 and 5a139f0e951e#11518

Merged
HyeockJinKim merged 4 commits intomainfrom
chore/alembic-merge-heads-vfolder-endpoint
May 8, 2026
Merged

fix: merge alembic heads c7d58e2a4f93 and 5a139f0e951e#11518
HyeockJinKim merged 4 commits intomainfrom
chore/alembic-merge-heads-vfolder-endpoint

Conversation

@jopemachine
Copy link
Copy Markdown
Member

Summary

Two migrations landed on main with the same parent so check-multiple-alembic-heads is now failing on every PR opened against main:

Add an empty merge revision (6b8149885649) pointing at both heads so alembic upgrade head resolves to a single tip again. No schema changes; upgrade()/downgrade() are intentionally no-ops.

Test plan

  • python scripts/check-multiple-alembic-heads.py reports a single head (6b8149885649) locally
  • pants lint / pants check clean on the new revision file
  • CI check-alembic-migrations green on this PR

🤖 Generated with Claude Code

Two migrations landed on main with the same parent
(``ba5923b1f4a7`` / ``3632aad9d5d9`` chain split):

- ``c7d58e2a4f93`` -- drop_endpoint_name_unique_index (BA-5974)
- ``5a139f0e951e`` -- add_updated_at_to_vfolders (BA-5504)

``check-multiple-alembic-heads`` now fails on every PR until the chain
is reconciled. Add an empty merge revision pointing at both heads so
``alembic upgrade head`` resolves to a single tip again. No schema
changes; the upgrade/downgrade bodies are intentionally no-ops.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Copilot AI review requested due to automatic review settings May 8, 2026 05:08
@github-actions github-actions Bot added size:S 10~30 LoC comp:manager Related to Manager component require:db-migration Automatically set when alembic migrations are added or updated labels May 8, 2026
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Note

Copilot was unable to run its full agentic suite in this review.

Adds an Alembic merge migration to reconcile two diverged heads so alembic upgrade head resolves to a single tip again (no schema changes).

Changes:

  • Introduce a no-op Alembic merge revision pointing to both existing heads.
  • Add a changelog entry documenting the fix.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
src/ai/backend/manager/models/alembic/versions/6b8149885649_merge_c7d58e2a4f93_and_5a139f0e951e.py Adds a merge revision that reunifies two Alembic heads with no-op upgrade/downgrade.
changes/11518.fix.md Documents the migration-head reconciliation in the changelog.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@jopemachine jopemachine added the skip:changelog Make the action workflow to skip towncrier check label May 8, 2026
@jopemachine jopemachine requested a review from a team May 8, 2026 05:10
seedspirit
seedspirit previously approved these changes May 8, 2026
@seedspirit seedspirit enabled auto-merge (squash) May 8, 2026 05:12
Add a one-line note to the module docstring so a future reader can tell
at a glance that this revision is a head-merge with no schema changes,
not an incomplete migration.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
@HyeockJinKim HyeockJinKim disabled auto-merge May 8, 2026 05:17
@HyeockJinKim HyeockJinKim merged commit 35aa1d5 into main May 8, 2026
23 checks passed
@HyeockJinKim HyeockJinKim deleted the chore/alembic-merge-heads-vfolder-endpoint branch May 8, 2026 05:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

comp:manager Related to Manager component require:db-migration Automatically set when alembic migrations are added or updated size:S 10~30 LoC skip:changelog Make the action workflow to skip towncrier check

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants