feat(BA-5827): AppConfigFragment foundation (DB + repository + errors) by jopemachine · Pull Request #11282 · lablup/backend.ai

jopemachine · 2026-04-24T07:18:22Z

📚 Stacked PRs

This PR is part of a 10-PR stack delivering BEP-1052. Merge in order:

⬇️ chore(BA-5822): drop legacy AppConfig layer (preparation for BEP-1052) #11265 — chore(BA-5822): drop legacy AppConfig layer
⬇️ feat(BA-5814): AppConfigPolicy foundation (data / repository / service / adapter, bulk-aware) #11266 — feat(BA-5814): AppConfigPolicy foundation
⬇️ feat(BA-5815): AppConfigPolicy GraphQL #11269 — feat(BA-5815): AppConfigPolicy GraphQL
⬇️ feat(BA-5844): AppConfigPolicy REST v2 surface #11312 — feat(BA-5844): AppConfigPolicy REST v2
👉 feat(BA-5827): AppConfigFragment foundation (DB + repository + errors) #11282 — feat(BA-5827): AppConfigFragment foundation ← you are here
⬇️ feat(BA-5836): AppConfigFragment service vertical (service / DTO / adapter) #11296 — feat(BA-5836): AppConfigFragment service vertical
⬇️ feat(BA-5829): AppConfigFragment + AppConfig GraphQL #11285 — feat(BA-5829): AppConfigFragment + AppConfig GraphQL
⬇️ feat(BA-5830): AppConfigFragment + AppConfig REST v2 #11286 — feat(BA-5830): AppConfigFragment + AppConfig REST v2
⬇️ feat(BA-5832): AppConfig v2 SDK + CLI (BEP-1052) #11295 — feat(BA-5832): AppConfig v2 SDK + CLI
⬇️ feat(BA-5837): ValkeyCache for AppConfigFragment merged-view reads #11298 — feat(BA-5837): ValkeyCache for AppConfigFragment merged-view reads

CI on intermediate PRs may show test churn since each one only lands a slice of the new layer. The full picture is guaranteed to build at the tip (#11298).

Summary

Lands the AppConfigFragment storage layer per BEP-1052 §1·§2:

app_config_fragments table + Alembic migration
ORM AppConfigFragmentRow
data/app_config_fragment/ value types
Repository slice (AppConfigFragmentRepository, AppConfigFragmentAdminRepository) with the shared Creator / Updater / Purger helpers; mutating methods use the Resilience policy + DB metrics layer
Domain errors (AppConfigFragmentConflict, AppConfigFragmentPolicyMissing, AppConfigFragmentNotFound)
Repository unit tests

The service / adapter / DTO surface and everything above (GQL, REST, SDK, CLI) layer on top in the subsequent stack PRs:

BA-5827 #11282  ← THIS PR  (foundation: DB + repo + errors + tests)
 └─ BA-5836 #11296          AppConfigFragment service vertical
     └─ BA-5829 #11285      AppConfigFragment + AppConfig GraphQL
         └─ BA-5830 #11286  AppConfigFragment + AppConfig REST
             └─ BA-5832 #11295  v2 SDK + CLI

Test plan

Repository unit tests pass
pants check clean on the foundation slice
CI green

📚 Documentation preview 📚: https://sorna--11282.org.readthedocs.build/en/11282/

📚 Documentation preview 📚: https://sorna-ko--11282.org.readthedocs.build/ko/11282/

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

…apter, bulk-aware) Layers the service / adapter / DTO surface on top of the AppConfigFragment foundation that BA-5827 (#11282) lands. Per BEP-1052 §3, all writes are bulk-only (admin + self-service) with partial-success semantics; reads expose `get`, scope-bound `search`, and cross-scope `admin_search`. - v2 DTOs (`common/dto/manager/v2/app_config_fragment/`) — shared by the GQL and REST surfaces in subsequent PRs. - Service + 8 action files + processor package; bulk actions extend `BaseBulkAction[T]` so `BulkActionProcessor` can route per-item validators (RBAC etc. — none wired yet, no-op forward). - Adapter (`api/adapters/app_config_fragment.py`) flesh-out, registered in the adapter registry; `bulk_create_my` / `bulk_update_my` pull `user_id` from `current_user()` instead of accepting it on the action. - Filter `conditions.py` and `orders.py` for typed Fragment search. - `services/factory.py` + `services/processors.py` wiring.

Lands the `app_config_fragments` storage layer per BEP-1052 §1·§2: table + Alembic migration, ORM row, data types, the repository slice (reads + writes via Creator/Updater/Purger helpers), domain errors, and the repository unit tests. The shared `Resilience` policy + DB metric layer are wired here too. The service / adapter / DTO / GQL+REST / SDK+CLI verticals layer on top in subsequent PRs.

…ssing key Mirrors the Policy-side test fix on BA-5814: the repository now raises rather than returning `None` for an unresolved natural key, so flip the assertion accordingly.

- Wrap AppConfigFragment repository / admin_repository methods with their own Resilience instances (mirrors the policy side from BA-5814). - Drop BEP-1052 §X references from doctrings, comments, the migration module, and the regression test — keep BEP wording only in the news fragment. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

…dater/Purger, rename extra_config - Drop `AppConfigFragmentPolicyMissing` (and the FK-violation integrity_error_check that mapped to it). The required-policy invariant is enforced upstream by the service layer; the DB-level FK is the defense-in-depth backstop and now surfaces as a generic `ForeignKeyViolationError`. The typed exception was premature for the DB+repository foundation slice — re-introduce later if a service/API layer needs it. - Refactor the admin_repository / db_source split: db_source now accepts pre-built `Updater` / `Purger` objects (mirroring `scaling_group`, `vfolder`, etc.), with the natural-key → PK resolution exposed as `resolve_pk_by_key`. `admin_repository` builds the `Updater` / `Purger` and translates the missing-row case into `AppConfigFragmentNotFound`. - Rename the JSONB column / Row attribute / Data field / Creator+Updater spec / admin-repository parameter from `extra_config` to `config` end-to-end (DB column included). The legacy-drop migration's downgrade keeps `extra_config` because it recreates the historical schema. - Update the regression test to expect the generic `ForeignKeyViolationError`. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

…apter, bulk-aware) Layers the service / adapter / DTO surface on top of the AppConfigFragment foundation that BA-5827 (#11282) lands. Per BEP-1052 §3, all writes are bulk-only (admin + self-service) with partial-success semantics; reads expose `get`, scope-bound `search`, and cross-scope `admin_search`. - v2 DTOs (`common/dto/manager/v2/app_config_fragment/`) — shared by the GQL and REST surfaces in subsequent PRs. - Service + 8 action files + processor package; bulk actions extend `BaseBulkAction[T]` so `BulkActionProcessor` can route per-item validators (RBAC etc. — none wired yet, no-op forward). - Adapter (`api/adapters/app_config_fragment.py`) flesh-out, registered in the adapter registry; `bulk_create_my` / `bulk_update_my` pull `user_id` from `current_user()` instead of accepting it on the action. - Filter `conditions.py` and `orders.py` for typed Fragment search. - `services/factory.py` + `services/processors.py` wiring.

github-actions Bot assigned jopemachine Apr 24, 2026

github-actions Bot added size:XL 500~ LoC comp:manager Related to Manager component require:db-migration Automatically set when alembic migrations are added or updated labels Apr 24, 2026

jopemachine added a commit that referenced this pull request Apr 24, 2026

docs(BA-5827): add news fragment for #11282

cc5852a

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

This was referenced Apr 24, 2026

feat(BA-5814): AppConfigPolicy foundation (data / repository / service / adapter, bulk-aware) #11266

Draft

chore(BA-5822): drop legacy AppConfig layer (preparation for BEP-1052) #11265

Draft

feat(BA-5815): AppConfigPolicy GraphQL #11269

Draft

jopemachine added a commit that referenced this pull request Apr 24, 2026

docs(BA-5827): add news fragment for #11282

34aa756

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

jopemachine force-pushed the BA-5827 branch from cc5852a to c2c4ab5 Compare April 24, 2026 07:35

jopemachine added a commit that referenced this pull request Apr 24, 2026

docs(BA-5827): add news fragment for #11282

0963201

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

jopemachine force-pushed the BA-5827 branch from c2c4ab5 to 1814807 Compare April 24, 2026 07:47

jopemachine added a commit that referenced this pull request Apr 24, 2026

docs(BA-5827): add news fragment for #11282

75257c6

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

jopemachine force-pushed the BA-5827 branch from 1814807 to c7eb94b Compare April 24, 2026 07:54

github-actions Bot added the comp:common Related to Common component label Apr 24, 2026

jopemachine added a commit that referenced this pull request Apr 24, 2026

docs(BA-5827): add news fragment for #11282

6c63ebb

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

jopemachine force-pushed the BA-5827 branch from c7eb94b to 7554204 Compare April 24, 2026 08:05

jopemachine added a commit that referenced this pull request Apr 24, 2026

docs(BA-5827): add news fragment for #11282

313e606

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

jopemachine force-pushed the BA-5827 branch from 7554204 to 4cc9378 Compare April 24, 2026 08:14

This was referenced Apr 24, 2026

feat(BA-5829): AppConfigFragment + AppConfig GraphQL #11285

Draft

feat(BA-5830): AppConfigFragment + AppConfig REST v2 #11286

Draft

jopemachine commented Apr 25, 2026

View reviewed changes

Comment thread src/ai/backend/common/dto/manager/v2/app_config_fragment/request.py Outdated

jopemachine commented Apr 25, 2026

View reviewed changes

Comment thread src/ai/backend/common/dto/manager/v2/app_config_fragment/request.py Outdated

jopemachine commented Apr 25, 2026

View reviewed changes

Comment thread src/ai/backend/common/dto/manager/v2/app_config_fragment/types.py Outdated

jopemachine commented Apr 25, 2026

View reviewed changes

Comment thread src/ai/backend/manager/services/app_config_fragment/actions/get.py Outdated

jopemachine force-pushed the BA-5814 branch from d78f510 to eac52b1 Compare April 25, 2026 04:59

jopemachine added a commit that referenced this pull request Apr 25, 2026

docs(BA-5827): add news fragment for #11282

fc40129

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

jopemachine force-pushed the BA-5827 branch from 4cc9378 to f575b11 Compare April 25, 2026 05:00

jopemachine changed the title ~~feat(BA-5827): app_config_fragments foundation (schema + ORM + data + repository)~~ feat(BA-5827): AppConfigFragment foundation (data / repository / service / adapter, bulk-aware) Apr 25, 2026

jopemachine added a commit that referenced this pull request Apr 25, 2026

docs(BA-5827): add news fragment for #11282

fe168ec

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

jopemachine force-pushed the BA-5827 branch from 2c45769 to 309c98a Compare April 25, 2026 09:48

jopemachine reopened this Apr 25, 2026

jopemachine force-pushed the BA-5815 branch from 309c98a to 7a44d32 Compare April 25, 2026 10:04

jopemachine force-pushed the BA-5827 branch from 85556a0 to 7dcf729 Compare April 25, 2026 10:05

jopemachine commented Apr 26, 2026

View reviewed changes

Comment thread src/ai/backend/manager/errors/app_config.py Outdated

jopemachine commented Apr 26, 2026

View reviewed changes

Comment thread src/ai/backend/manager/repositories/app_config_fragment/admin_repository.py Outdated

jopemachine commented Apr 26, 2026

View reviewed changes

Comment thread src/ai/backend/manager/models/app_config_fragment/row.py Outdated

jopemachine force-pushed the BA-5815 branch from 7a44d32 to 274560f Compare April 26, 2026 12:08

jopemachine force-pushed the BA-5827 branch from 7dcf729 to 063c903 Compare April 26, 2026 12:09

jopemachine mentioned this pull request Apr 26, 2026

feat(BA-5844): AppConfigPolicy REST v2 surface #11312

Draft

3 tasks

jopemachine force-pushed the BA-5827 branch from d3e3e91 to 82ee7ab Compare April 26, 2026 13:19

jopemachine changed the base branch from BA-5815 to BA-5844 April 26, 2026 13:24

jopemachine force-pushed the BA-5844 branch from 91a2910 to 4c33d8e Compare April 27, 2026 01:57

jopemachine force-pushed the BA-5827 branch from 82ee7ab to d9c0d9a Compare April 27, 2026 01:57

jopemachine force-pushed the BA-5844 branch from 4c33d8e to 2f117ba Compare April 27, 2026 02:10

jopemachine force-pushed the BA-5827 branch from e835649 to 1bea526 Compare April 27, 2026 02:10

jopemachine force-pushed the BA-5844 branch from 2f117ba to 481b114 Compare April 27, 2026 02:38

jopemachine and others added 5 commits April 27, 2026 11:38

test(BA-5827): expect AppConfigFragmentNotFound on Fragment update mi…

ff7426a

…ssing key Mirrors the Policy-side test fix on BA-5814: the repository now raises rather than returning `None` for an unresolved natural key, so flip the assertion accordingly.

chore(BA-5827): drop BEP-1052 ref from 11282 news fragment

923a7f8

jopemachine force-pushed the BA-5827 branch from 1bea526 to 923a7f8 Compare April 27, 2026 02:39

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(BA-5827): AppConfigFragment foundation (DB + repository + errors)#11282

feat(BA-5827): AppConfigFragment foundation (DB + repository + errors)#11282
jopemachine wants to merge 5 commits intoBA-5844from
BA-5827

jopemachine commented Apr 24, 2026 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Conversation

jopemachine commented Apr 24, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

📚 Stacked PRs

Summary

Test plan

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

jopemachine commented Apr 24, 2026 •

edited

Loading