remote/client: cleanup InteractiveCommandError#1788
Merged
jluebbe merged 1 commit intolabgrid-project:masterfrom Dec 18, 2025
Merged
remote/client: cleanup InteractiveCommandError#1788jluebbe merged 1 commit intolabgrid-project:masterfrom
jluebbe merged 1 commit intolabgrid-project:masterfrom
Conversation
When handling InteractiveCommandError there is an implicit assumption that it has a field `exitcode`. This assumption holds since in all places it is raised there is the same repeated code block. Make this assumption more explicit by providing a proper constructor to InteractiveCommandError class. Signed-off-by: Sebastian Gross <sgross@emlix.com>
Contributor
Author
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1788 +/- ##
======================================
Coverage 45.0% 45.1%
======================================
Files 172 172
Lines 13630 13618 -12
======================================
Hits 6144 6144
+ Misses 7486 7474 -12
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
jluebbe
approved these changes
Dec 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When handling InteractiveCommandError there is an implicit assumption that it has a field
exitcode.This assumption holds since in all places it is raised there is the same repeated code block.
Make this assumption more explicit by providing a proper constructor to InteractiveCommandError class.