feat: adds http delete support to cel expressions by gaganhr94 · Pull Request #55 · kyverno/sdk

gaganhr94 · 2026-03-08T05:51:12Z

Explanation

This PR adds HTTP DELETE method support to the Kyverno SDK CEL HTTP library. Currently, the library only supports GET, POST operations. The DELETE method is essential for removing resources from remote HTTP endpoints. This enhancement allows users to make DELETE requests with custom headers from within CEL expressions, enabling complete resource lifecycle management in policy expressions, including resource deletion scenarios.

Related issue

Fixes kyverno/kyverno#15472
Dependent on the merge of PR #54, post which we can rebase this branch on main and review

Proposed Changes

The DELETE implementation mirrors the existing POST method pattern to maintain consistency across the codebase. These changes will add support to the delete method (say, for example http.Delete() being used in the CEL expressions)

Checklist

I have read the contributing guidelines.
I have read the PR documentation guide and followed the process including adding proof manifests to this PR.
This is a bug fix and I have added unit tests that prove my fix is effective.

Further Comments

codecov-commenter · 2026-03-08T05:52:37Z

Codecov Report

❌ Patch coverage is 79.85612% with 28 lines in your changes missing coverage. Please review.
✅ Project coverage is 70.84%. Comparing base (376d911) to head (63e4f9b).

Files with missing lines	Patch %	Lines
extensions/cel/libs/http/http.go	51.51%	8 Missing and 8 partials ⚠️
extensions/cel/libs/http/impl.go	79.31%	5 Missing and 7 partials ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main      #55      +/-   ##
==========================================
+ Coverage   70.35%   70.84%   +0.49%     
==========================================
  Files          80       80              
  Lines        2540     2679     +139     
==========================================
+ Hits         1787     1898     +111     
- Misses        602      615      +13     
- Partials      151      166      +15

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Signed-off-by: Gagan H R <hrgagan4@gmail.com>

Copilot

Pull request overview

Adds additional HTTP verb support to the Kyverno SDK CEL http library so CEL expressions can perform more REST operations (notably DELETE as requested in the PR description).

Changes:

Extends the HTTP CEL surface area with new member function overloads for Put, Patch, and Delete (plus camelCase variants for v1.18+).
Implements Put, Patch, and Delete request execution in the HTTP context implementation.
Adds unit tests covering PUT/PATCH/DELETE request execution and some argument validation paths.

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 5 comments.

Show a summary per file

File	Description
`extensions/cel/libs/http/types.go`	Expands the exported HTTP context interface with additional verb methods.
`extensions/cel/libs/http/lib.go`	Registers new CEL member overloads for `Put`/`Patch`/`Delete` (Pascal + camelCase).
`extensions/cel/libs/http/impl.go`	Adds CEL binding implementations for PUT/PATCH/DELETE.
`extensions/cel/libs/http/http.go`	Implements PUT/PATCH/DELETE on the underlying HTTP client context.
`extensions/cel/libs/http/impl_test.go`	Adds tests for PUT/PATCH/DELETE behavior and some error cases.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-04-25T11:17:27Z

 type ContextInterface interface {
 	Get(url string, headers map[string]string) (any, error)
 	Post(url string, data any, headers map[string]string) (any, error)
+	Put(url string, data any, headers map[string]string) (any, error)
+	Patch(url string, data any, headers map[string]string) (any, error)
+	Delete(url string, headers map[string]string) (any, error)
 	Client(caBundle string) (ContextInterface, error)


Adding Put/Patch/Delete to the exported ContextInterface is a breaking change for any downstream code that provides its own implementation of this interface (their types will no longer satisfy it). To keep backward compatibility, consider keeping ContextInterface as-is and instead adding Put/Patch/Delete methods on the exported Context wrapper (delegating to the embedded value via optional interface assertions), or introduce a new extended interface and accept that type where needed.

Copilot · 2026-04-25T11:17:28Z

 	libraryDecls := map[string][]cel.FunctionOpt{
 		"Get":    buildGetOverloads("pascal"),
 		"Post":   buildPostOverloads("pascal"),
+		"Put":    buildPutOverloads("pascal"),
+		"Patch":  buildPatchOverloads("pascal"),
+		"Delete": buildDeleteOverloads("pascal"),
 		"Client": buildClientOverloads("pascal"),
 	}

 	if c.version.AtLeast(version.MajorMinor(1, 18)) {
 		libraryDecls["get"] = buildGetOverloads("camel")
 		libraryDecls["post"] = buildPostOverloads("camel")
+		libraryDecls["put"] = buildPutOverloads("camel")
+		libraryDecls["patch"] = buildPatchOverloads("camel")
+		libraryDecls["delete"] = buildDeleteOverloads("camel")
 		libraryDecls["client"] = buildClientOverloads("camel")


The PR description is about adding DELETE support, but this change set also introduces PUT and PATCH declarations/overloads. If those are coming from a dependent PR, it would be better to rebase/split so this PR only contains the DELETE-related diff (or update the PR description/scope accordingly) to keep review and release notes accurate.

Copilot · 2026-04-25T11:17:28Z

+	body, err := buildRequestData(data)
+	if err != nil {
+		return nil, fmt.Errorf("failed to encode request data: %w", err)
+	}


Put/Patch now call buildRequestData(), but buildRequestData currently hard-codes "HTTP POST" in its encode error message. This will produce confusing errors for PUT/PATCH requests; consider making the error message method-agnostic (or pass the HTTP verb into buildRequestData and include it in the message).

Copilot · 2026-04-25T11:17:28Z

+func Test_impl_put_request(t *testing.T) {
+	base, err := compiler.NewBaseEnv()
+	assert.NoError(t, err)
+	assert.NotNil(t, base)
+
+	ctx := Context{&contextImpl{
+		client: testClient{
+			doFunc: func(req *http.Request) (*http.Response, error) {
+				assert.Equal(t, req.URL.String(), "http://localhost:8080")
+				assert.Equal(t, req.Method, "PUT")
+
+				var data any
+				err := json.NewDecoder(req.Body).Decode(&data)
+				assert.NoError(t, err)
+				assert.Equal(t, data.(map[string]any)["key"], "value")
+				assert.Equal(t, data.(map[string]any)["foo"], float64(2))
+
+				return &http.Response{StatusCode: http.StatusOK, Body: io.NopCloser(strings.NewReader(`{"body": "updated"}`))}, nil
+			},
+		},
+	}}
+
+	env, err := base.Extend(
+		Lib(&ctx, version.MajorMinor(1, 18)),
+	)
+	assert.NoError(t, err)
+	assert.NotNil(t, env)
+	ast, issues := env.Compile(`http.Put("http://localhost:8080", { "key": dyn("value"), "foo": dyn(2) })`)
+	fmt.Println(issues.String())


The newly added PUT/PATCH/DELETE tests only exercise the PascalCase methods (http.Put/http.Patch/http.Delete). Since the library also conditionally registers the camelCase variants for version >= 1.18, please add at least one test per verb that compiles/evals http.put/http.patch/http.delete to ensure those overloads are actually wired correctly.

Copilot · 2026-04-25T11:17:28Z

+	ast, issues := env.Compile(`http.Put("http://localhost:8080", { "key": dyn("value"), "foo": dyn(2) })`)
+	fmt.Println(issues.String())
+	assert.Nil(t, issues)
+	assert.NotNil(t, ast)
+	prog, err := env.Program(ast)
+	assert.NoError(t, err)
+	assert.NotNil(t, prog)
+
+	out, _, err := prog.Eval(map[string]any{})
+	assert.NoError(t, err)
+	body := out.Value().(map[string]any)
+	assert.Equal(t, body["body"], "updated")
+	assert.Equal(t, body["statusCode"], http.StatusOK)
+}
+
+func Test_impl_put_request_with_headers(t *testing.T) {
+	base, err := compiler.NewBaseEnv()
+	assert.NoError(t, err)
+	assert.NotNil(t, base)
+
+	ctx := Context{&contextImpl{
+		client: testClient{
+			doFunc: func(req *http.Request) (*http.Response, error) {
+				assert.Equal(t, req.URL.String(), "http://localhost:8080")
+				assert.Equal(t, req.Method, "PUT")
+				assert.Equal(t, req.Header.Get("Authorization"), "Bearer token")
+
+				var data any
+				err := json.NewDecoder(req.Body).Decode(&data)
+				assert.NoError(t, err)
+				assert.Equal(t, data.(map[string]any)["key"], "value")
+
+				return &http.Response{StatusCode: http.StatusOK, Body: io.NopCloser(strings.NewReader(`{"body": "updated"}`))}, nil
+			},
+		},
+	}}
+
+	env, err := base.Extend(
+		Lib(&ctx, version.MajorMinor(1, 18)),
+	)
+	assert.NoError(t, err)
+	assert.NotNil(t, env)
+	ast, issues := env.Compile(`http.Put("http://localhost:8080", {"key": "value"}, {"Authorization": "Bearer token"})`)
+	fmt.Println(issues.String())
+	assert.Nil(t, issues)


These fmt.Println(issues.String()) statements add noisy output to the test suite and aren't needed for assertions. Consider removing them (or only logging when issues != nil and issues.Err() != nil).

gaganhr94 added 3 commits April 25, 2026 10:51

feat: adds http put support to cel expressions

8f29b4a

Signed-off-by: Gagan H R <hrgagan4@gmail.com>

feat: adds http patch support to cel expressions

2329184

Signed-off-by: Gagan H R <hrgagan4@gmail.com>

feat: adds http delete support to cel expressions

63e4f9b

Signed-off-by: Gagan H R <hrgagan4@gmail.com>

Copilot AI review requested due to automatic review settings April 25, 2026 11:12

gaganhr94 force-pushed the feat/http-delete-support branch from e6b6aa4 to 63e4f9b Compare April 25, 2026 11:12

Copilot started reviewing on behalf of gaganhr94 April 25, 2026 11:12 View session

Copilot AI reviewed Apr 25, 2026

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

feat: adds http delete support to cel expressions#55

feat: adds http delete support to cel expressions#55
gaganhr94 wants to merge 3 commits into
kyverno:mainfrom
gaganhr94:feat/http-delete-support

gaganhr94 commented Mar 8, 2026

Uh oh!

codecov-commenter commented Mar 8, 2026 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Apr 25, 2026

Uh oh!

Copilot AI Apr 25, 2026

Uh oh!

Copilot AI Apr 25, 2026

Uh oh!

Copilot AI Apr 25, 2026

Uh oh!

Copilot AI Apr 25, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Uh oh!

Conversation

gaganhr94 commented Mar 8, 2026

Explanation

Related issue

Proposed Changes

Checklist

Further Comments

Uh oh!

codecov-commenter commented Mar 8, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI Apr 25, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 25, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 25, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 25, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 25, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

codecov-commenter commented Mar 8, 2026 •

edited

Loading